Jira (PUP-5923) Administration token detection doesn't work in legacy Windows OS (2003/XP)

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti created an issue   Puppet / PUP-5923 Administration token detection doesn't work in legacy Windows OS (2003/XP) Issue Type: Bug Assignee: Unassigned Created: 2016/02/18 10:40 AM Fix Versions: PUP 4.4.0 Labels: windows Priority: Normal Reporter: Glenn Sarti As part of PUP-5735 it was found that the administrative token detection for legacy operating systems always evaluated as true. This was due to a simple typo at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/user.rb#L46 The helper function returns a bool type however the check is against an integer. Therefore is_admin is always returns because bool <> int32 is always true. Changing the line to is_admin = ismember_pointer.read_win32_bool fixes the problem Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.