Jira (PUP-5930) If a 3.x function calls a 4.x function via the new function API with the same name, Puppet server crashes

[Zachary Smith (JIRA)]

Title: Message Title

Zachary Smith created an issue   Puppet / PUP-5930 If a 3.x function calls a 4.x function via the new function API with the same name, Puppet server crashes Issue Type: Bug Affects Versions: PUP 4.2.2 Assignee: Unassigned Components: Puppet Server Created: 2016/02/19 11:38 AM Priority: Normal Reporter: Zachary Smith I was playing around with the new function api and was curios if I could have an old and new function named the same thing. I wrote some code that looked like this: # 4.x Puppet::Functions.create_function(:get_ldap_group) do then a glue code 3.x function Puppet::Parser::Functions::newfunction(:get_ldap_group, :type => :rvalue) do |args| # Condtionally require the new gems and check puppet version # to see if we need to use the old function during migration. # This can be removed once migration to Puppet Enterprise is complete if Puppet::Util::Package.versioncmp(Puppet.version, '4.0.0') >= 0 Puppet.debug('Using the Puppet 4 function API to call get ldap group') ldap_groups = call_function('get_ldap_group', args) else Puppet.debug('Using the Puppet 3 function API to call get ldap group') ldap_groups = function_legacy_get_ldap_group(args) end ldap_groups end This crashed puppetserver within a few minutes, my assumption is that it was some kind of recursive function call on itself. We should probably have some sanity checks for this. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.