Jira (PUP-5968) Deprecate Symbol#<=> monkey patch

Josh Cooper (JIRA) Wed, 24 Feb 2016 09:23:57 -0800

Title: Message Title

Josh Cooper commented on

PUP-5968

FWIW, if I add a raise to the monkey patch: raise "Not a Symbol" unless other.is_a?(Symbol), then puppet specs still pass. Also executing the following also works (so the monkey patch is no longer necessary for the original use case that caused it to be added):

$ bundle exec puppet resource user root

user { 'root':

  ensure   => 'present',

  comment  => 'System Administrator',

  gid      => '0',

  groups   => ['admin', 'certusers', 'daemon', 'foobar', 'kmem', 'operator', 'procmod', 'procview', 'staff', 'sys', 'tty', 'wheel'],

  home     => '/var/root',

  password => '*',

  shell    => '/bin/sh',

  uid      => '0',

The code path is still called in https://github.com/puppetlabs/puppet/blob/fdc85d3cc05ee2c79140027237143517162a3321/lib/puppet/resource.rb#L388, so it seems parameters.keys always contains symbols.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-5968) Deprecate Symbol#<=> monkey patch

Reply via email to