Jira (PUP-5995) Stray UTF-8 character in manifest comment corrupts parsed parameters

[Jeremy Barlow (JIRA)]

Title: Message Title

Jeremy Barlow created an issue   Puppet / PUP-5995 Stray UTF-8 character in manifest comment corrupts parsed parameters Issue Type: Bug Assignee: Unassigned Attachments: parse.pp Created: 2016/03/01 10:38 AM Priority: Normal Reporter: Jeremy Barlow If I have the Puppet::InfoService::ClassInformationService or resource_types endpoint parse a manifest which includes a special UTF-8 character in a comment, the resulting default values parsed for parameters appear to be corrupted. Here is the manifest file I used for this test, also attached as "parse.pp": # Ѐ class myclass ( String $a_string = "this is a string", Integer $an_integer = 3, ) {} Note that the character at the end of the comment line is a Cyrillic Capital letter Ye with grave, Unicode code point of U+4000, hex representation of 0xD080 in UTF-8 in the file. Running the following code... require 'puppet' require 'puppet/info_service'   files_to_parse = { "production" => [ "./parse.pp" ] }   puts Puppet::InfoService::ClassInformationService.new.classes_per_environment(files_to_parse) ... produces the following output: {"production"=>{"./parse.pp"=>{:classes=>[{:name=>"myclass", :params=>[{:name=>"a_string", :type=>"String", :default_literal=>"this is a string", :default_source=>"this is a string\","}, {:name=>"an_integer", :type=>"Integer", :default_literal=>3, :default_source=>","}]}]}}} The `:default_literal` values for each parameter appear to be correct but the `:default_source` values do not. Instead of "this is a string\",", I would have expected "\"this is a string\"". Instead of ",", I would have expected "3". This problem does not appear to be unique to the ClassInformationService. I get the same error when I use the "resource_types" endpoint to query for this data. For a query to "https://localhost:8140/puppet/v3/resource_types/*?kind=class&environment=production" where the "parse.pp" file is stored under the "<code-dir>/environments/production/modules/mymodule/manifests" directory, I get the following response (pretty-printed for display): [ { "kind": "class", "line": 2, "name": "myclass", "parameters": { "a_string": "this is a string\",", "an_integer": "," } } ] Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.