Jira (HI-501) {{%{literal(...)\}}} can appear only once in any data value

[Johnson Earls (JIRA)]

Title: Message Title

Johnson Earls created an issue   Hiera / HI-501 {{%{literal(...)\}}} can appear only once in any data value Issue Type: Bug Affects Versions: HI 3.0.1 Assignee: Jenny Mahmoudi Components: UX Created: 2016/03/02 11:43 AM Priority: Normal Reporter: Johnson Earls Multiple identical calls to the Hiera lookup function %{literal()} in the same Hiera data key cause an error. This includes when the %{hiera()} or %{alias()} lookup functions are called and the included keys contain identical %{literal()} calls. However, it works when using %{hiera()} to include two different Hiera keys that contain identical %{literal()} calls. # grep test_ /etc/puppetlabs/code/hieradata/hosts/`hostname`.yaml test_01_works: "%{literal('%')}A" test_02_works: "%{literal('%')}%{literal('B')}" test_03_works: [ "%{literal('%')}C" , "%{literal('%')}D" ] test_04_works: "%{hiera('test_01_works')}%{hiera('test_02_works')}" test_05_fails: "%{hiera('test_01_works')}%{hiera('test_01_works')}" test_06_fails: "%{literal('%')}E%{literal('%')}" test_07_fails: "%{hiera('test_03_works')}" test_08_fails: "%{alias('test_03_works')}" # puppet apply -t --noop -e 'warning(hiera("test_01_works"))' | egrep 'Warning|Error' Warning: Scope(Class[main]): %A   # puppet apply -t --noop -e 'warning(hiera("test_02_works"))' | egrep 'Warning|Error' Warning: Scope(Class[main]): %B   # puppet apply -t --noop -e 'warning(hiera("test_03_works"))' | egrep 'Warning|Error' Warning: Scope(Class[main]): [%C, %D]   # puppet apply -t --noop -e 'warning(hiera("test_04_works"))' | egrep 'Warning|Error' Warning: Scope(Class[main]): %A%B   # puppet apply -t --noop -e 'warning(hiera("test_05_fails"))' | egrep 'Warning|Error' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [hiera('test_01_works')] at line 1:9 on node puppet01-ord12.ord12.responsys.com   # puppet apply -t --noop -e 'warning(hiera("test_06_fails"))' | egrep 'Warning|Error' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [literal('%')] at line 1:9 on node puppet01-ord12.ord12.responsys.com   # puppet apply -t --noop -e 'warning(hiera("test_07_fails"))' | egrep 'Warning|Error' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [hiera('test_03_works'), literal('%')] at line 1:9 on node puppet01-ord12.ord12.responsys.com   # puppet apply -t --noop -e 'warning(hiera("test_08_fails"))' | egrep 'Warning|Error' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [alias('test_03_works'), literal('%')] at line 1:9 on node puppet01-ord12.ord12.responsys.com Given that the only stated valid parameter to %{literal()} in the Hiera documentation is '%', this means it is nearly impossible (and certainly difficult) to generically include multiple % characters in a single Hiera key. For example, if you need four % signs in a single data value: p1: "%{literal('%')}" p2: "%{literal('%')}" p3: "%{literal('%')}" p4: "%{literal('%')}"   apache::vhost::standard_rewrites: - comment: rewrite to canonical URL rewrite_cond: - "%{hiera('p1')}{HTTP_HOST} !^www\\.example\\.com [NC]" - "%{hiera('p2')}{HTTP_HOST} !^$" - "%{hiera('p3')}{SERVER_PORT} !^80$" rewrite_rule: - "^/(.*) http://www.example.com:%{hiera('p4')}{SERVER_PORT}/$1 [L,R]"   apache::vhost: foo.example.com: port: '80' docroot: '/var/www' rewrites: "%{alias('apache::vhost::standard_rewrites')}" The only way you can access apache::vhost in this example is if each of the % signs in the apache::vhost::standard_rewrites data value come from different Hiera keys that contain a %{literal('%')}: # puppet apply -t --noop -e 'warning(hiera("apache::vhost"))' | egrep 'Error|Warning' Warning: Scope(Class[main]): {foo.example.com => {port => 80, docroot => /var/www, rewrites => [{comment => rewrite to canonical URL, rewrite_cond => [%{HTTP_HOST} !^www\.example\.com [NC], %{HTTP_HOST} !^$, %{SERVER_PORT} !^80$], rewrite_rule => [^/(.*) http://www.example.com:%{SERVER_PORT}/$1 [L,R]]}]}} If, instead, you use the obvious (and documented) solution... apache::vhost::standard_rewrites: - comment: rewrite to canonical URL rewrite_cond: - "%{literal('%')}{HTTP_HOST} !^www\\.example\\.com [NC]" - "%{literal('%')}{HTTP_HOST} !^$" - "%{literal('%')}{SERVER_PORT} !^80$" rewrite_rule: - "^/(.*) http://www.example.com:%{literal('%')}{SERVER_PORT}/$1 [L,R]"   apache::vhost: foo.example.com: port: '80' docroot: '/var/www' rewrites: "%{alias('apache::vhost::standard_rewrites')}" You get this error: # puppet apply -t --noop -e 'warning(hiera("apache::vhost"))' | egrep 'Error|Warning' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [alias('apache::vhost::standard_rewrites'), literal('%')] at line 1:9 on node puppet01-ord12.ord12.responsys.com Even if you use a single level of redirection... percent: "%{literal('%')}"   apache::vhost::standard_rewrites: - comment: rewrite to canonical URL rewrite_cond: - "%{hiera('percent')}{HTTP_HOST} !^www\\.example\\.com [NC]" - "%{hiera('percent')}{HTTP_HOST} !^$" - "%{hiera('percent')}{SERVER_PORT} !^80$" rewrite_rule: - "^/(.*) http://www.example.com:%{hiera('percent')}{SERVER_PORT}/$1 [L,R]"   apache::vhost: foo.example.com: port: '80' docroot: '/var/www' rewrites: "%{alias('apache::vhost::standard_rewrites')}" You still get an error: # puppet apply -t --noop -e 'warning(hiera("apache::vhost"))' | egrep 'Error|Warning' Error: Evaluation Error: Error while evaluating a Function Call, Detected in [alias('apache::vhost::standard_rewrites'), hiera('percent')] at line 1:9 on node puppet01-ord12.ord12.responsys.com Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.