Jira (PUP-6026) Audit Windows::Error.new for additional eaten exceptions

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown created an issue   Puppet / PUP-6026 Audit Windows::Error.new for additional eaten exceptions Issue Type: Task Affects Versions: PUP 4.3.2 Assignee: Unassigned Created: 2016/03/08 8:52 PM Fix Versions: PUP 4.4.1 Priority: Normal Reporter: Ethan Brown In PUP-6025 it was discovered that we've been silently and expensively eating instances of Windows::Error being thrown, that were failing because a Windows API is being used incorrectly. Since this was discovered accidentally, I think it makes sense to do a quick audit, by instrumenting the code with some rudimentary logging, to see if there are other cases like this. The instrumentation doesn't need to be much more complex than adding something like this to the initializer of the class at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/error.rb#L16: open('c:/win-error.txt', 'a') { |f| f << "#{@code}: #{message}\n" } Further exploration could add the callers details so we have a better idea of where the errors are originating to see if there are any patterns. The net result of this ticket should be new tickets. Add Comment   This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.