Issue #2782 has been updated by Al Hoang.
Hi there, Since I originated this ticket / patch request I think I should chime in just to clarify some things. Markus Roberts wrote: > I'm marking this "Code Insufficient" I think this is reasonable. I started work on getting Puppet to run on Ruby 1.9 however I've not had a lot of time to look into this recently but have been wanting to pick it up again and complete it. > > 1. Contains fragments of an older version of #2781 > 2. Does not merge cleanly on master This makes sense and I was hoping to keep up with upstream in my branch on github however it has fallen way behind. > 3. Duplicates some of the changes that are being made in the code smell > process I'm not sure I understand what this means. If you had time to explain this, that would be very helpful. Otherwise, I'll take your word for it. > 4. Fixes things in ways that don't make sense (e.g. guarding > @resource.stat(false) with a version check when none of the stat methods took > a boolean parameter even in 1.8) Thanks for pointing this out. I'd prefer a cleaner way to get it working. I believe you suggested a cleaner methodology awhile back on the mailing list but I've not had time to go back and review your suggestions again. The changesets I have on github reflected my really strong desire (at the time) to have something running over a clean implementation so please take that github branch with a grain of salt. > My intent is to manually go through the changes after the dust settles and > come up with a patch that addresses the things that need to be fixed with a > new branch, perhaps based on this one. This sounds reasonable to me. If you know of a way to perhaps split what needs to be done such that I can help that would be great. ---------------------------------------- Bug #2782: Changes in Ruby 1.9.x const_set and const_get prevent puppetd from properly executing http://projects.puppetlabs.com/issues/2782 Author: Al Hoang Status: Code Insufficient Priority: Low Assigned to: Markus Roberts Category: unknown Target version: queued Affected version: 0.25.1 Keywords: Ruby 1.9 Branch: http://github.com/hoanga/puppet/tree/0.25.x_1.9.1 Hello, Attached is a patch with modifications to get puppetd to properly execute when puppetd --trace --verbose --debug is run on the command line. Some changes are: * Explicitly use the top-level File object in lib/puppet/type/file.rb * Add some checks on RUBY_VERSION and avoid called @resource.stat(false) * Call a Ruby 1.8.x compatible version of const_defined? if RUBY_VERSION looks like it is 1.9.x Here are some useful links that might help explain some of the changes to const_set and const_set in Ruby 1.9.x: http://issues.apache.org/jira/browse/BUILDR-140 http://jira.codehaus.org/browse/JRUBY-4197 http://redmine.ruby-lang.org/issues/show/1915 http://markmail.org/message/zr5vh2333yr3k3qi Please note that this assumes that the changes from ticket #2781 are already applied -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
