Issue #3856 has been updated by Paul Nasrat. Status changed from Unreviewed to Tests Insufficient
I'm not sure your test works correctly, rake spec gives: 1) NoMethodError in 'Facter::Util::Virtual should detect virtualbox' undefined method `virtualbox?' for Facter::Util::Virtual:Module ./spec/unit/util/virtual.rb:105: Finished in 3.196373 seconds Your code change just lib/facter/virtual.rb and your unit test is for the facter/util/virtual.rb which is probably the wrong place. ---------------------------------------- Bug #3856: Facter doesn't detect VirtualBox as a virtual http://projects.puppetlabs.com/issues/3856 Author: John Ferlito Status: Tests Insufficient Priority: Normal Assigned to: Category: library Target version: Keywords: Branch: Facter thinks virtualbox VMs are physical servers -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
