Jira (FACT-1395) Replace Facter 2.x WMI Operating System kernel query with Windows API

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown created an issue   Facter / FACT-1395 Replace Facter 2.x WMI Operating System kernel query with Windows API Issue Type: Improvement Affects Versions: FACT 2.4.6 Assignee: Unassigned Components: Windows Created: 2016/04/18 2:37 PM Fix Versions: FACT 2.4.7 Priority: Normal Reporter: Ethan Brown Currently there are 2 WMI queries used to retrieve the operating system release version for Windows: SELECT version, producttype FROM Win32_OperatingSystem at https://github.com/puppetlabs/facter/blob/2.x/lib/facter/operatingsystem/windows.rb#L9 SELECT version FROM Win32_OperatingSystem at https://github.com/puppetlabs/facter/blob/2.x/lib/facter/kernelrelease.rb#L44 To enable broader OS support, we can simply use the GetVersionEx API call, as long as we use the OSVERSIONINFOEX structure to retrieve wProductType Note that as of Windows 8.1, there are some interesting notes about how that API has changed that are worth validating - Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2). Once an application is manifested for a given operating system version, GetVersionEx will always return the version that the application is manifested for in future releases. To manifest your applications for Windows 8.1 or Windows 10, refer to Targeting your application for Windows. - this points to docs at https://msdn.microsoft.com/en-us/library/windows/desktop/dn481241(v=vs.85).aspx Alternatively, we can use GetProductInfo, which requires a minimum of Windows 2008 and will return Major / Minor versions, but not the equivalent of wProductType, which is used for some older 2003 / XP detection (that could probably be rewritten). There are also some Version Helper APIs, but it's unclear which OS version they support. Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.