Jira (PUP-6216) Puppet agent run is not clearing USER environment variable on VIO AIX

[Adam Bottchen (JIRA)]

Title: Message Title

Adam Bottchen created an issue   Puppet / PUP-6216 Puppet agent run is not clearing USER environment variable on VIO AIX Issue Type: Bug Affects Versions: PUP 4.4.1 Assignee: Kylo Ginsberg Components: Client Created: 2016/04/21 11:23 AM Priority: Normal Reporter: Adam Bottchen Puppet agent is not clearing the USER environment variable before executing crontab -l on AIX VIO servers. This leads to errors during puppet runs: # /opt/puppetlabs/bin/puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for pitavios.delivery.puppetlabs.net Info: Applying configuration version '1461261696' Error: Could not prefetch cron provider 'crontab' target 'padmin': Could not read crontab for padmin: Execution of 'crontab -l' returned 1: can't open yourfile in /var/spool/cron/crontabs directory. No such file or directory. Treating as empty Notice: Applied catalog in 1.22 seconds The reason is that on VIO servers, users log in initially as the padmin user and then switch to root using the oem_setup_env command. This command leaves USER=padmin in the environment. When the puppet agent hits puppet/util/filetype.rb to pull the crontab data, it is still looking for the padmin user's crontab rather than root. I have found two ways to avoid this issue. 1. Prepend the puppet run with a USER environment variable override: `USER=root /opt/puppetlabs/bin/puppet agent -t` 2. Apply the patch --- ruby/vendor_ruby/puppet/util/execution.rb.orig 2016-04-21 11:16:18.774322000 -0700 +++ ruby/vendor_ruby/puppet/util/execution.rb 2016-04-21 11:17:11.378321989 -0700 @@ -263,6 +263,7 @@ # @api private # def self.execute_posix(command, options, stdin, stdout, stderr) + Puppet::Util::POSIX::USER_ENV_VARS.each { |name| ENV.delete(name) } child_pid = Puppet::Util.safe_posix_fork(stdin, stdout, stderr) do   # We can't just call Array(command), and rely on it returning To move the deletion of these environment variables outside the fork code. Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.