Jira (FACT-1408) Facter productname issue on Solaris

[Ali Tukimin (JIRA)]

Title: Message Title

Ali Tukimin created an issue   Facter / FACT-1408 Facter productname issue on Solaris Issue Type: Bug Affects Versions: FACT 3.1.3 Assignee: Unassigned Components: PE Created: 2016/05/03 7:13 PM Priority: Normal Reporter: Ali Tukimin Somewhere in the transition from the facter shipping with PE 3.8.1 and that shipping with 2015.3 the productname fact on Solaris seems to have been broken in a couple of ways. On a system running the old agent # /opt/puppet/bin/facter --version 2.4.4 # /opt/puppet/bin/facter -p productname SPARC Enterprise M5000 Server From looking at the ruby code, this seems to come from parsing the output of the prtdiag command bash-3.2# prtdiag | head -1 System Configuration: Oracle Corporation sun4u SPARC Enterprise M5000 Server Now, on a system with the new agent: # /opt/puppetlabs/bin/facter --version 3.1.3 (commit 1aa380a82ec35b7f8e7e58fab627e74f93aaeff3) # /opt/puppetlabs/bin/facter -p productname SPARC-Enterprise This seems to be done in libfacter, and I can't immediately see where, but looks like it's doing something equivalent to this: # prtconf | grep '^ *SUNW,' | head -1 | sed 's/.*,//' SPARC-Enterprise Now, there are 2 problems here: 1) We have lost information. This is a less specific description of the host model, and 2) On later machines, it doesn't work at all. More detail on 2: On newer hardware we get: # /opt/puppetlabs/bin/facter -p productname builtin-drivers (driver not attached) This seems to be because on older machines: # prtconf | grep '^ *SUNW,' SUNW,SPARC-Enterprise SUNW,probe-error-handler (driver not attached) SUNW,builtin-drivers (driver not attached) SUNW,qlc, instance #0 SUNW,qlc, instance #1 SUNW,qlc, instance #2 SUNW,qlc, instance #3 But on a newer machine, we get this: # prtconf | grep '^ *SUNW,' SUNW,builtin-drivers (driver not attached) SUNW,asr (driver not attached) Why? Because this: # prtconf | egrep '^ *(SUNW|ORCL),' ORCL,SPARC-T4-4 SUNW,builtin-drivers (driver not attached) SUNW,asr (driver not attached) In any case, a version based on prtdiag would still work: # prtdiag | head -1 System Configuration: Oracle Corporation sun4v SPARC T4-4 Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.