Jira (FACT-1415) Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown created an issue   Facter / FACT-1415 Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion Issue Type: Improvement Affects Versions: FACT 3.1.6 Assignee: Unassigned Components: Windows Created: 2016/05/10 4:59 PM Fix Versions: FACT 3.1.7 Labels: windows Priority: Normal Reporter: Ethan Brown Currently the version for kernel32.dll is discovered by using GetFileVersionInfoW in the kernel resolver, and that's passed out as the OS version - https://github.com/puppetlabs/facter/blob/master/lib/src/facts/windows/kernel_resolver.cc#L16-L60 However, it's uncertain if that's the best path forward. Historically we could use the GetVersionEx API - however, as of Windows 8.1, there are some interesting notes about how that API has changed: Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2). Once an application is manifested for a given operating system version, GetVersionEx will always return the version that the application is manifested for in future releases. To manifest your applications for Windows 8.1 or Windows 10, refer to Targeting your application for Windows. - this points to docs at https://msdn.microsoft.com/en-us/library/windows/desktop/dn481241(v=vs.85).aspx It's uncertain if the current kernel32.dll approach will experience the same issue as GetVersionEx, but the code in Facter 2.x has been changed to use RtlGetVersion instead per FACT-1395 Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.