Issue #4006 has been updated by Matt Robinson. Status changed from Ready for Testing to Ready for Checkin Branch set to http://github.com/mmrobins/puppet/tree/bug/0.25.x/4006-stub_method_introduced_while_reverting_2890_to_clean_up_test_failures
I'm still not clear who should be setting the ready for checkin on status or when that's appropriate, but Markus reviewed this change so I'm going to set it as such. ---------------------------------------- Bug #4006: Fix XMLRPCClient test errors - Retrieved certificate does not match private key http://projects.puppetlabs.com/issues/4006 Author: Matt Robinson Status: Ready for Checkin Priority: Normal Assigned to: Markus Roberts Category: testing Target version: Affected version: 0.25.5 Keywords: revert test failure Branch: http://github.com/mmrobins/puppet/tree/bug/0.25.x/4006-stub_method_introduced_while_reverting_2890_to_clean_up_test_failures When Markus reverted changes made by 2890 he reintroduced a method certificate_matches_key? that then caused failures in network/xmlrpc/client.rb. I just stubbed that method to return true since the failing tests weren't trying to test that methods behavior. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
