Jira (PUP-6385) undef no longer an accepted value for require/before resource metaparams

[Dominic Cleal (JIRA)]

Title: Message Title

Dominic Cleal commented on PUP-6385   Re: undef no longer an accepted value for require/before resource metaparams The issue in the module is still present on 4.5.1 when instantiating the resource through stdlib's ensure_packages (a create_resources wrapper), as it's not declared directly in the manifest. I think it's doing the equivalent of this: $ bin/puppet apply -v --noop -e '$r = undef; create_resources("Package", {"a" => {"require" => $r}})' --trace Error: No title provided and "undef" is not a valid resource reference on node cobalt /home/dcleal/code/puppet/puppet/lib/puppet/resource.rb:544:in `extract_type_and_title' /home/dcleal/code/puppet/puppet/lib/puppet/resource.rb:529:in `type_and_title' /home/dcleal/code/puppet/puppet/lib/puppet/resource/catalog.rb:353:in `resource' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:34:in `block in validate_relationship' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:32:in `each' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:32:in `validate_relationship' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:10:in `block (2 levels) in validate' /home/dcleal/code/puppet/puppet/lib/puppet/parser/resource.rb:51:in `block in eachparam' /home/dcleal/code/puppet/puppet/lib/puppet/parser/resource.rb:50:in `each' /home/dcleal/code/puppet/puppet/lib/puppet/parser/resource.rb:50:in `eachparam' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:8:in `block in validate' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:6:in `each' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:6:in `validate' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:217:in `block in validate_catalog' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:217:in `each' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:217:in `validate_catalog' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:205:in `block (2 levels) in compile' /home/dcleal/code/puppet/puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile' /home/dcleal/code/puppet/puppet/lib/puppet/util/profiler.rb:51:in `profile' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:204:in `block in compile' /home/dcleal/code/puppet/puppet/lib/puppet/context.rb:65:in `override' /home/dcleal/code/puppet/puppet/lib/puppet.rb:240:in `override' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:167:in `compile' /home/dcleal/code/puppet/puppet/lib/puppet/parser/compiler.rb:35:in `compile' /home/dcleal/code/puppet/puppet/lib/puppet/indirector/catalog/compiler.rb:266:in `block (2 levels) in compile' /home/dcleal/code/puppet/puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile' /home/dcleal/code/puppet/puppet/lib/puppet/util/profiler.rb:51:in `profile' /home/dcleal/code/puppet/puppet/lib/puppet/indirector/catalog/compiler.rb:264:in `block in compile' /home/dcleal/code/puppet/puppet/lib/puppet/util.rb:223:in `block in benchmark' /home/dcleal/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/1.9.1/benchmark.rb:295:in `realtime' /home/dcleal/code/puppet/puppet/lib/puppet/util.rb:222:in `benchmark' /home/dcleal/code/puppet/puppet/lib/puppet/indirector/catalog/compiler.rb:262:in `compile' /home/dcleal/code/puppet/puppet/lib/puppet/indirector/catalog/compiler.rb:53:in `find' /home/dcleal/code/puppet/puppet/lib/puppet/indirector/indirection.rb:194:in `find' /home/dcleal/code/puppet/puppet/lib/puppet/application/apply.rb:256:in `block in main' /home/dcleal/code/puppet/puppet/lib/puppet/context.rb:65:in `override' /home/dcleal/code/puppet/puppet/lib/puppet.rb:240:in `override' /home/dcleal/code/puppet/puppet/lib/puppet/application/apply.rb:225:in `main' /home/dcleal/code/puppet/puppet/lib/puppet/application/apply.rb:170:in `run_command' /home/dcleal/code/puppet/puppet/lib/puppet/application.rb:344:in `block in run' /home/dcleal/code/puppet/puppet/lib/puppet/util.rb:540:in `exit_on_fail' /home/dcleal/code/puppet/puppet/lib/puppet/application.rb:344:in `run' /home/dcleal/code/puppet/puppet/lib/puppet/util/command_line.rb:128:in `run' /home/dcleal/code/puppet/puppet/lib/puppet/util/command_line.rb:72:in `execute' /home/dcleal/code/puppet/puppet/bin/puppet:5:in `<main>' (on master) This used to be ignored on 4.4.2: $ bin/puppet apply -v --noop -e '$r = undef; create_resources("Package", {"a" => {"require" => $r}})' Notice: Compiled catalog for cobalt in environment production in 0.65 seconds Info: Applying configuration version '1464989385' and raises a warning on f14b653 (commit prior to PUP-6028 ): $ bin/puppet apply -v --noop -e '$r = undef; create_resources("Package", {"a" => {"require" => $r}})' Warning: Could not find resource 'undef' in parameter 'require' (file & line not available) Notice: Compiled catalog for cobalt in environment production in 0.64 seconds Info: Applying configuration version '1464989408' Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.