Jira (PUP-6401) deprecated symbol monkey patch code path is always executed when running puppet under jruby

[Chris Price (JIRA)]

Title: Message Title

Chris Price commented on PUP-6401   Re: deprecated symbol monkey patch code path is always executed when running puppet under jruby Here is a branch where I've added some print statements to the symbol monkey patch: https://github.com/cprice404/puppet/tree/scratch/master/PUP-6401-symbol-deprecation-under-jruby-example With these changes, if you attempt to start webrick under JRuby, you will see a ton of print output indicating places where the comparator is being called when it wouldn't be under MRI. Also, when running under Puppet Server, we do get warn messages logged from the pops/type.rb; when attempting to start webrick under JRuby those warn-level log messages do not show up, even though "puts" output does. I haven't figured out why yet; it may be because of the fact that we are using a symbol equality comparison inside of the implementation of symbol equality comparison : (I'm referring to the "case" statement on Puppet[:strict] below.) class Symbol def <=> (other) puts "SYMBOL COMPARISON: '#{self}' (#{self.class}), '#{other}' (#{other.class})" if (other.class != Symbol) case Puppet[:strict] when :warning Puppet.warn_once('deprecation', 'symbol_comparison', 'Comparing Symbols to non-Symbol values is deprecated') when :error raise ArgumentError.new("Comparing Symbols to non-Symbol values is no longer allowed") end end self.to_s <=> other.to_s end end Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.