Jira (PUP-6425) Regression: puppet help errors out if any application raises while generating help

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-6425 Regression: puppet help errors out if any application raises while generating help Issue Type: Bug Assignee: Unassigned Created: 2016/06/21 6:00 PM Priority: Normal Reporter: Josh Cooper PUP-3521 (commit eccd3b modified puppet to not swallow errors silently, but it causes a regression because the result variable is not in scope. To reproduce, modify an app in lib/puppet/application/*.rb to raise an ArgumentError in its help method, then run: bundle exec puppet help Error: undefined local variable or method `result' for #<Puppet::Interface:0x007fab1b563218> ... The problem line is: rescue StandardError result << [ "! #{appname}", "! Subcommand unavailable due to error. Check error logs." ] end Although the reproduction steps are contrived, I ran into this problem when I had an application in a module and the application called Puppet.settings.initialize_settings twice, which causes puppet to raise an exception. Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.