Jira (PDB-2866) PuppetDB should always return JSON

Brian Cain (JIRA) Tue, 12 Jul 2016 09:45:31 -0700

Title: Message Title

Brian Cain created an issue

PDB-2866

Issue Type:	Bug
Assignee:	Unassigned
Created:	2016/07/12 9:44 AM
Priority:	Normal
Reporter:	Brian Cain

If PuppetDB encounters an exception from a given query, or is given an incorrect query, it does not return json. This makes it difficult for the consumer to figure out what went wrong.

With a query that causes an exception: ["=", "deactivated", false]

[root@xevuii7pbf15o9l ~]# curl -G https://$(hostname -f):8081/pdb/query/v4/nodes --cacert /etc/puppetlabs/puppet/ssl/certs/ca.pem --cert /etc/puppetlabs/puppet/ssl/certs/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --key /etc/puppetlabs/puppet/ssl/private_keys/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --data-urlencode 'query=["=", "deactivated", false]'

<html>

<head>

<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>

<title>Error 500 </title>

</head>

<body>

<h2>HTTP ERROR: 500</h2>

<p>Problem accessing /pdb/query/v4/nodes. Reason:

<pre>    org.postgresql.util.PSQLException: ERROR: operator does not exist: timestamp with time zone = boolean

  Hint: No operator matches the given name and argument type(s). You might need to add explicit type casts.

  Position: 1335</pre></p>

<hr /><i><small>Powered by Jetty://</small></i>

</body>

</html>

With an query that doesn't cause an exception, but is still a malformed query ["=", "deactivated", null, "asdflkjasdf"]:

[root@xevuii7pbf15o9l ~]# curl -G https://$(hostname -f):8081/pdb/query/v4/nodes --cacert /etc/puppetlabs/puppet/ssl/certs/ca.pem --cert /etc/puppetlabs/puppet/ssl/certs/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --key /etc/puppetlabs/puppet/ssl/private_keys/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --data-urlencode 'query=["=", "deactivated", null, "asdflkjasdf"]'

= requires exactly two arguments

In both cases, the consumer is expecting json but fails to parse both results since neither are json.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PDB-2866) PuppetDB should always return JSON

Reply via email to