Jira (FACT-1405) Facter does not like next hop flags in ip route output

[Sean Griffin (JIRA)]

Title: Message Title

Sean Griffin commented on FACT-1405   Re: Facter does not like next hop flags in ip route output The fix doesn't seem to work. On the our pooler's ubuntu 16.04 vm, 'ip route show' does not add 'onlink' at the end of the default interface line. To test this I replaced the ip command so that it returns a line for the default interface with 'onlink' added to make it behave like the user's description. During its execution, 'facter networking' calls ip 4 times. If called with the first argument being 'link' then the original ip command is invoked (/bin/ip). Here is the replacement ip command: PuppetLabs382:01-160714 sgriffin$ cat ip #! /bin/bash   echo $* >> /tmp/ip-args   if [ "$1" = "link" ] then /bin/ip $* exit $? elif [ "$1" = "-6" ] then echo "fe80::/64 dev ens32 proto kernel metric 256 pref medium" else echo "default via 188.166.0.1 dev ens32 onlink" echo "10.18.0.0/16 dev eth0 proto kernel scope link src 10.18.0.5" fi If this bug were fixed, then the older version of facter (3.4.0 (commit 039f23fa2daa57ce252a0903bc580a8a19ab746c)) would show the error and the new version (3.4.0 (commit d4e6922ce49a6b4c3a764d26815c9cc93ece3dbd)) would not. However, both versions show the error message. old: root@y99ds7qhf6srqml:/sbin# facter --version 3.4.0 (commit 039f23fa2daa57ce252a0903bc580a8a19ab746c) root@y99ds7qhf6srqml:/sbin# facter networking 2016-07-14 17:05:46.486468 WARN puppetlabs.facter - Could not process routing table entry: Expected a destination followed by key/value pairs, got 'default via 188.166.0.1 dev ens32 onlink' { dhcp => "10.32.22.10", ... new: root@fyg3le9zbfm5kez:/sbin# facter --version 3.4.0 (commit d4e6922ce49a6b4c3a764d26815c9cc93ece3dbd) root@fyg3le9zbfm5kez:/sbin# facter --version 3.4.0 (commit d4e6922ce49a6b4c3a764d26815c9cc93ece3dbd) root@fyg3le9zbfm5kez:/sbin# facter networking 2016-07-14 17:06:15.888928 WARN puppetlabs.facter - Could not process routing table entry: Expected a destination followed by key/value pairs, got 'default via 188.166.0.1 dev ens32 onlink' { dhcp => "10.32.22.9", ... Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.