Jira (PUP-5723) Poor error reporting when metadata.json is incorrect or incomplete

[John Duarte (JIRA)]

Title: Message Title

John Duarte commented on PUP-5723   Re: Poor error reporting when metadata.json is incorrect or incomplete Validated using a pre-release version of puppet-agent at SHA 277f09e containing puppet at SHA 9807733 Reproduction steps Install motd module puppet module install puppetlabs-motd Modify metadata.json to invalidate Add trailing comma at end of requirements array ... "requirements": [ { "name": "pe", "version_requirement": ">= 3.0.0 < 2015.4.0" }, { "name": "puppet", "version_requirement": ">= 3.0.0 < 5.0.0" } ], } Run puppet apply without strict Execute puppet apply without the --strict flag to ensure that the invalid metadata.json is reported as a Warning root@je7458qow3pf0u1:~# puppet apply -e 'include motd' Warning: motd has an invalid and unparsable metadata.json file. The parse error: 757: unexpected token at '{ "name": "puppetlabs-motd", ... ], } ' Notice: Compiled catalog for je7458qow3pf0u1.delivery.puppetlabs.net in environment production in 0.21 seconds Notice: /Stage[main]/Motd/File[/etc/motd]/content: content changed '{md5}9830e3dbb6a828f2cc824db8db0ceaf7' to '{md5}0fb6ce9abff0910bbd0590348183735f' Notice: Applied catalog in 0.04 seconds Run puppet apply with strict Execute puppet apply with --strict=error flag to ensure that the invalid metadata.json is reported as a Error root@je7458qow3pf0u1:~# puppet apply --strict error -e 'include motd' Error: motd has an invalid and unparsable metadata.json file. The parse error: 757: unexpected token at '{ "name": "puppetlabs-motd", ... ], } ' Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::motd for je7458qow3pf0u1.delivery.puppetlabs.net at line 1:1 on node je7458qow3pf0u1.delivery.puppetlabs.net Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.