Jira (FACT-1479) Occasional stack overflow triggered by Facter::EC2::Base

[Saj Goonatilleke (JIRA)]

Title: Message Title

Saj Goonatilleke created an issue   Facter / FACT-1479 Occasional stack overflow triggered by Facter::EC2::Base Issue Type: Bug Affects Versions: FACT 2.4.6 Assignee: Unassigned Created: 2016/08/04 5:25 AM Environment: Debian 7 (wheezy) Linux 3.2.0 MRI 1.9.3p194 Facter 2.4.6 Priority: Normal Reporter: Saj Goonatilleke While investigating FACT-1478, I found I was occasionally able to overflow the MRI stack (SystemStackError) simply by executing the following program: require 'facter/ec2/rest' exit 1 unless Facter::EC2::Metadata.new.reachable? I think this issue has to do with the use of Timeout.timeout in facter/ec2/rest.rb. Use of Timeout has been widely documented to be ill-advised – see here, here, and here. I was unable to reproduce this problem after replacing Timeout.timeout with the :read_timeout option to open(). On MRI, :read_timeout has been implemented using non-blocking reads and IO.select, which will not result in non-deterministic behaviour when the timeout elapses. Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.