Jira (PUP-6654) @property_hash not updated in OSX user directoryservice provider

[John Duarte (JIRA)]

Title: Message Title

John Duarte created an issue   Puppet / PUP-6654 @property_hash not updated in OSX user directoryservice provider Issue Type: Bug Affects Versions: PUP 4.6.1 Assignee: Unassigned Created: 2016/08/25 2:35 PM Priority: Normal Reporter: John Duarte It would be desirable to refacter the logic in the OSX user directoryservice provider to check the @property_hash value for the existence of the desired user as shown in this PR. However, after a call to the `create` method, @property_hash is empty. Thus if this refactoring was implemented, a call to puppet to ensue a new user would return an indicator of ensure => absent even though the user was successfully created. Steps to create on OSX Install Puppet Agent curl -O http://downloads.puppetlabs.com/mac/10.11/PC1/x86_64/puppet-agent-1.6.1-1.osx10.11.dmg sudo hdiutil mount puppet-agent-1.6.1-1.osx10.11.dmg sudo installer -pkg /Volumes/puppet-agent-1.6.1-1.osx10.11/puppet-agent-1.6.1-1-installer.pkg -target / sudo umount /Volumes/puppet-agent-1.6.1-1.osx10.11 Patch user/directoryservice provider Change to provider/user directory cd /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/user/ Create patch file cat <<\EOF > patch --- directoryservice.rb +++ directoryservice.rb @@ -237,13 +237,7 @@ ## ##   def exists? - begin - dscl '.', 'read', "/Users/#{@resource.name}" - rescue Puppet::ExecutionFailure => e - Puppet.debug("User was not found, dscl returned: #{e.inspect}") - return false - end - true + return @property_hash.any? end   # This method is called if ensure => present is passed and the exists? EOF Apply the patch patch directoryservice.rb patch Create new user with provider and notice failure Notice in the user creation output below that puppet returns an erroneous absent result. When we query puppet a second time, we can see that the user was successfully created. e:user root# /opt/puppetlabs/bin/puppet resource user bar ensure=present Notice: /User[bar]/ensure: created user { 'bar': ensure => 'absent', } e:user root# /opt/puppetlabs/bin/puppet resource user bar user { 'bar': ensure => 'present', ... uid => '29', } Add Comment   This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.