Jira (PUP-6723) collector_transformer: negation query for array type properties is broken

[Isaiah Frantz (JIRA)]

Title: Message Title

Isaiah Frantz commented on PUP-6723   Re: collector_transformer: negation query for array type properties is broken I would argue that the way negation works currently breaks the basic logic of the search query. The two existing tests, one for tag properties and one for a mix of arrays bends my mind a little. In this case, I would expect to match the objects that dont contain the search term. In the case of == we use compare_operator.include? if the property is an array so that we can include objects that contain the term. It only makes sense to do the opposite with logical negation, i.e. exclude the entire object when it contains the term. Perhaps the cleaner way to code this section would be to always run the == case, then if the actual operator is !=, return the negation of the == case The fact that you get back objects that contain the term you dont want doesnt compute it "does not exclude resources with unequal arrays" do expect_the_message_to_be(["message", ["not this message", "or this one"]], <<-MANIFEST) @notify { "testing": message => "message" } @notify { "the wrong one": message => ["not this message", "or this one"] } Notify <| message != "not this message" |> MANIFEST end This case is the one that is actually affecting me. My default User settings include 'ensure => absent'. I have a tag array in each user with the realms they should exist in since we have many separate environments. Also, I have some tags for admin users of various types. In the users::init I collect all the classes of admin and realm groups and users and override the ensure to '=> present' and add "wanted" to the tags array. Then at the bottom I want to collect all the users and groups that <| tag != 'wanted' and tag != 'IGNORE' |> (IGNORE is for legacy users that I know I want to manage on specific realms but could exist elsewhere that I wouldn't want it removed from) This system lets me clean a user from all systems or create them in others based on the presence or removal of a tag entry. I also use this to control sudo by giving their tag for a realm a "_sudoers" postfix which adds them to a $ {realm} _sudoers group which is also added to the sudoers file via template. it "does not exclude tags with inequalities" do expect_the_message_to_be(["wanted message", "the way it works"], <<-MANIFEST) @notify { "testing": tag => ["wanted"], message => "wanted message" } @notify { "other": tag => ["why"], message => "the way it works" } Notify <| tag != "why" |> MANIFEST end My change makes both of these cases work as I logically expect. I would be pretty shocked if anybody used negation in collectors on array type properties (tag included) since they would have beaten their heads against it matching things incorrectly for a while and then given up on it. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.