Jira (PUP-6744) deprecate unrecognized escapes in strings

[David Schmitt (JIRA)]

Title: Message Title

David Schmitt created an issue   Puppet / PUP-6744 deprecate unrecognized escapes in strings Issue Type: Improvement Affects Versions: PUP 4.7.0 Assignee: Unassigned Created: 2016/09/27 6:16 AM Environment: puppet 4.7.0 ruby 2.3.1p112 (2016-04-26) [x86_64-linux-gnu] Priority: Normal Reporter: David Schmitt Observe: $ cat ~/tmp/notice.pp notice('1 bs: \1') notice('2 bs: \\1') notice('3 bs: \\\1') notice('4 bs: \\\\1')   $ bundle exec puppet apply ~/tmp/notice.pp Notice: Scope(Class[main]): 1 bs: \1 Notice: Scope(Class[main]): 2 bs: \1 Notice: Scope(Class[main]): 3 bs: \\1 Notice: Scope(Class[main]): 4 bs: \\1 Notice: Compiled catalog for davids.corp.puppetlabs.net in environment production in 0.07 seconds Notice: Applied catalog in 0.03 seconds $ vi ~/tmp/notice.pp $ cat ~/tmp/notice.pp notice("1 bs: \1") notice("2 bs: \\1") notice("3 bs: \\\1") notice("4 bs: \\\\1") $ bundle exec puppet apply ~/tmp/notice.pp Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:1:18 Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:3:20 Notice: Scope(Class[main]): 1 bs: \1 Notice: Scope(Class[main]): 2 bs: \1 Notice: Scope(Class[main]): 3 bs: \\1 Notice: Scope(Class[main]): 4 bs: \\1 Notice: Compiled catalog for davids.corp.puppetlabs.net in environment production in 0.06 seconds Notice: Applied catalog in 0.03 seconds $ bundle exec puppet apply ~/tmp/notice.pp --strict=error Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:1:18 Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:3:20 Notice: Scope(Class[main]): 1 bs: \1 Notice: Scope(Class[main]): 2 bs: \1 Notice: Scope(Class[main]): 3 bs: \\1 Notice: Scope(Class[main]): 4 bs: \\1 Notice: Compiled catalog for davids.corp.puppetlabs.net in environment production in 0.08 seconds Notice: Applied catalog in 0.03 seconds $ bundle exec puppet apply ~/tmp/notice.pp --strict=off Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:1:18 Warning: Unrecognized escape sequence '\1' at /home/david/tmp/notice.pp:3:20 Notice: Scope(Class[main]): 1 bs: \1 Notice: Scope(Class[main]): 2 bs: \1 Notice: Scope(Class[main]): 3 bs: \\1 Notice: Scope(Class[main]): 4 bs: \\1 Notice: Compiled catalog for davids.corp.puppetlabs.net in environment production in 0.06 seconds Notice: Applied catalog in 0.03 seconds $ This behaviour is confusing and dangerous. See PUP-6709 and DOCUMENT-586 for some fall out from this. Expected behaviour: unrecognized escape sequences are treated the same in single and double quoted strings the warning for unrecognized escape sequences should be controllable by --strict Unless --strict=off is set, unrecognized escape sequences should be recognized and reported to the user. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.