Jira (PUP-6756) Puppet::FileBucket::Dipper specs fail silently

[Shawn Ferry (JIRA)]

Title: Message Title

Shawn Ferry created an issue   Puppet / PUP-6756 Puppet::FileBucket::Dipper specs fail silently Issue Type: Bug Assignee: Unassigned Created: 2016/09/28 1:13 PM Environment: Solaris 11+ Priority: Normal Reporter: Shawn Ferry dipper_spec assumes gnu diff AND executes diff via ``s notably this fails on Solaris but may also fail on other platforms Current rspec spec/unit/file_bucket/dipper_spec.rb Run options: exclude {:broken=>true, :benchmark=>true} ....diff: illegal option -- N usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2 diff [-bitw] [-C number | -U number] file1 file2 diff [-bitw] [-D string] file1 file2 diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2 diff: illegal option -- N usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2 diff [-bitw] [-C number | -U number] file1 file2 diff [-bitw] [-D string] file1 file2 diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2 ..diff: illegal option -- N usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2 diff [-bitw] [-C number | -U number] file1 file2 diff [-bitw] [-D string] file1 file2 diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2 diff: illegal option -- N usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2 diff [-bitw] [-C number | -U number] file1 file2 diff [-bitw] [-D string] file1 file2 diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2 ................................   Finished in 1.6 seconds (files took 2.47 seconds to load) 38 examples, 0 failures With Puppet::Util::Execution.execute rspec spec/unit/file_bucket/dipper_spec.rb Run options: exclude {:broken=>true, :benchmark=>true} ....F.F...............................   Failures:   1) Puppet::FileBucket::Dipper when diffing on a local filebucket in non-windows environments when digest_algorithm is md5 should properly diff files on the filebucket Failure/Error: expect(@dipper.diff(checksum1, checksum2, nil, nil)).to include(diff12)   expected "--- /tmp/rspecrun20160928-29191-mm3g5/bucket20160928-29191-ucq5dv/a/a/e/e/8/e/f/2/aaee8ef2aebce5861b...e7/contents\t2016-09-28 13:05:52.245200560 -0700\n@@ -1 +1 @@\n-OriginalContent\n+ModifiedContent\n" to include "diff: illegal option -- N\nusage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2\n dif...n diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2\n" Diff: @@ -1,2 +1,6 @@ -diff: illegal option -- N\nusage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2\n diff [-bitw] [-C number | -U number] file1 file2\n diff [-bitw] [-D string] file1 file2\n diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2\n +--- /tmp/rspecrun20160928-29191-mm3g5/bucket20160928-29191-ucq5dv/a/a/e/e/8/e/f/2/aaee8ef2aebce5861bddd2c59afdf3f1/contents 2016-09-28 13:05:52.244125030 -0700 ++++ /tmp/rspecrun20160928-29191-mm3g5/bucket20160928-29191-ucq5dv/7/c/3/0/c/6/c/4/7c30c6c414286afdd1ad6b78cf6c75e7/contents 2016-09-28 13:05:52.245200560 -0700 +@@ -1 +1 @@ +-OriginalContent ++ModifiedContent # ./spec/unit/file_bucket/dipper_spec.rb:111:in `block (5 levels) in <top (required)>'   ...   Finished in 1.15 seconds (files took 3.46 seconds to load) 38 examples, 2 failures   Failed examples:   rspec ./spec/unit/file_bucket/dipper_spec.rb[1:3:1:1:2] # Puppet::FileBucket::Dipper when diffing on a local filebucket in non-windows environments when digest_algorithm is md5 should properly diff files on the filebucket rspec ./spec/unit/file_bucket/dipper_spec.rb[1:3:1:2:2] # Puppet::FileBucket::Dipper when diffing on a local filebucket in non-windows environments when digest_algorithm is sha256 should properly diff files on the filebucket After rspec spec/unit/file_bucket/dipper_spec.rb Run options: exclude {:broken=>true, :benchmark=>true} ......................................   Finished in 2.24 seconds (files took 3.6 seconds to load) 38 examples, 0 failures Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.