Jira (FACT-1492) FACT [OS][RELEASE][MAJOR] returns FULL version instead of MAJOR version on WIndows Server 2016

[Moses Mendoza (JIRA)]

Title: Message Title

Moses Mendoza commented on FACT-1492   Re: FACT [OS][RELEASE][MAJOR] returns FULL version instead of MAJOR version on WIndows Server 2016 Maggie Dreyer I think that is indeed what we want. As you noted, for the server platforms [os][release][full] and [os][release][major] we've done the year (+ release number if present) string, and we want to keep that behavior for Windows Server 2016. E.g., we should get back {os => {"release"=>{"major"=>"2016", "full"=>"2016"}}} AFAICT the only distinction between long and short versions on the server platforms comes from the kernel version facts, ie on Server 2012 R2: kernelmajversion => 6.3 kernelrelease => 6.3.9600 kernelversion => 6.3.9600 For Windows 10 (and other consumer versions) I believe we should indeed use the first integer of the kernel version as the value for os release major, ie facter should return {os => {"release"=>{"major"=>"10", "full"=>"10.0.10586"}}} and for kernel version facts: kernelmajversion => 10.0 kernelrelease => 10.0.10586 kernelversion => 10.0.10586 It is interesting though - facter 2 also used to return a "minor" version of the structured fact, ie on Windows 10, Facter 2.4.6: os => {"name"=>"windows", "family"=>"windows", "release"=>{"major"=>"10", "minor"=>"0", "full"=>"10.0.10586"}} I wonder if it was intention to cease reporting the "minor" version? cc Ethan Brownh Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.