Jira (PUP-6800) Better error messaging around invalid class names

[Nick Walker (JIRA)]

Title: Message Title

Nick Walker commented on PUP-6800   Re: Better error messaging around invalid class names So, I think we have a bug around how the puppet master searches for the file on disk that holds a class. Allow me to demonstrate with some examples. I see three factors: 1. The name of the .pp file we put the class in 2. The name of the class 3. The name of the class when we try to include it Lower case, everything works [root@master201640-centos modules]# pwd /etc/puppetlabs/code/environments/production/modules [root@master201640-centos modules]# tree . └── role └── manifests └── appserver └── windows_2012r2.pp   3 directories, 1 file [root@master201640-centos modules]# cat role/manifests/appserver/windows_2012r2.pp class role::appserver::windows_2012r2 { notify { 'test' :} } [root@master201640-centos modules]# puppet apply -e "include role::appserver::windows_2012r2" Notice: Compiled catalog for master201640-centos in environment production in 0.08 seconds Notice: test Notice: /Stage[main]/Role::Appserver::Windows_2012r2/Notify[test]/message: defined 'message' as 'test' Notice: Applied catalog in 0.21 seconds Lower case file name and class name but include upper case class name ( works ). This is unexpected. [root@master201640-centos modules]# pwd; tree; cat role/manifests/appserver/windows_2012r2.pp /etc/puppetlabs/code/environments/production/modules . └── role └── manifests └── appserver └── windows_2012r2.pp   3 directories, 1 file class role::appserver::windows_2012r2 { notify { 'test' :} } [root@master201640-centos modules]# puppet apply -e "include role::appserver::windows_2012R2" Notice: Compiled catalog for master201640-centos in environment production in 0.09 seconds Notice: test Notice: /Stage[main]/Role::Appserver::Windows_2012r2/Notify[test]/message: defined 'message' as 'test' Notice: Applied catalog in 0.23 seconds lower case file name, upper case class name, include upper case class name ( works ). this is also unexpected. [root@master201640-centos modules]# pwd; tree; cat role/manifests/appserver/windows_2012r2.pp /etc/puppetlabs/code/environments/production/modules . └── role └── manifests └── appserver └── windows_2012r2.pp   3 directories, 1 file class role::appserver::windows_2012R2 { notify { 'test' :} } [root@master201640-centos modules]# puppet apply -e "include role::appserver::windows_2012R2" Notice: Compiled catalog for master201640-centos in environment production in 0.09 seconds Notice: test Notice: /Stage[main]/Role::Appserver::Windows_2012r2/Notify[test]/message: defined 'message' as 'test' Notice: Applied catalog in 0.19 seconds Finally, the case we expect to work that doesn't. Upper case file name, upper case class name, include upper case class name ( does not work) [root@master201640-centos modules]# mv role/manifests/appserver/windows_2012r2.pp role/manifests/appserver/windows_2012R2.pp [root@master201640-centos modules]# pwd; tree; cat role/manifests/appserver/windows_2012R2.pp /etc/puppetlabs/code/environments/production/modules . └── role └── manifests └── appserver └── windows_2012R2.pp   3 directories, 1 file class role::appserver::windows_2012R2 { notify { 'test' :} } [root@master201640-centos modules]# puppet apply -e "include role::appserver::windows_2012R2" Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::role::appserver::windows_2012r2 for master201640-centos at line 1:1 on node master201640-centos I also tested upper case file name, lower case file name and it doesn't work when including upper or lower case class name. So, I'm fairly certain this issue has to do with how the puppet master finds the class files on disk. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.