Jira (PUP-6856) data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently

[David Schmitt (JIRA)]

Title: Message Title

David Schmitt created an issue   Puppet / PUP-6856 data-in-modules: missing facts during building of the hierarchy fails the lookup completely and silently Issue Type: Bug Affects Versions: PUP 4.7.0 Assignee: Unassigned Created: 2016/11/01 9:14 AM Priority: Normal Reporter: David Schmitt When building the hierarchy for looking up data in modules, lib/puppet/data_providers/hiera_config.rb the interpolation around https://github.com/puppetlabs/puppet/blob/4.7.0/lib/puppet/data_providers/hiera_config.rb#L101 does weird things causing the whole lookup to fail, instead of ignoring that hierarchy level reporting a specific error This can easily be reproduced by adding the following code to spec/classes/test_spec.rb into https://github.com/puppetlabs/puppetlabs-ntp/tree/c4f586c8eabc879837942febbb70d30dc4d614ac and running bundle install --without system_tests bundle exec rake spec_prep bundle exec rspec spec/classes/test_spec.rb require 'spec_helper'   describe 'ntp' do context 'without facts' do it { is_expected.to compile } end   context 'with the full version missing' do let :facts do { os: { name: 'Debian', family: 'Debian', release: { major: 'stretch/sid' } } } end   it { is_expected.to compile } end   context 'with full facts' do let :facts do { os: { name: 'Debian', family: 'Debian', release: { major: 'stretch/sid', full: 'stretch/sid' } } } end   it { is_expected.to compile } end end The first two tests fail with none of the values with default values in Debian.yaml or common.yaml being applied. The last one has all the facts for the hierarchy and suddenly works, although only the os.family should be required. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.