Jira (PUP-6883) Unlisted module dependency in metadata.json results in weird errors

[Rune Juhl Jacobsen (JIRA)]

Title: Message Title

Rune Juhl Jacobsen created an issue   Puppet / PUP-6883 Unlisted module dependency in metadata.json results in weird errors Issue Type: Bug Affects Versions: PUP 4.7.0 Assignee: Unassigned Created: 2016/11/04 5:58 AM Labels: metadata Priority: Normal Reporter: Rune Juhl Jacobsen Changing our modules to use Hiera instead of params.pp meant that some of our modules got a metadata.json file which had been missing before. As dependencies seem to be enforced religiously when a module has a metadata.json file, this has been the cause of some weird errors. Without metadata.json dependencies would be resolved just fine. With a metadata.json with a unlisted dependency on a module providing a function we got errors like the following: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Scope variable name false is a FalseClass, not a string at /etc/puppetlabs/code/envs/rune/modules/enableit/profile/manifests/storage/nas.pp:32:3 at /etc/puppetlabs/code/envs/rune/modules/enableit/profile/manifests/storage/nas.pp:19 on node testnode1.enableit The cause of this is a bit weird. During our transition to Puppet 4 we ended up having two Ruby functions with the same name, one with a Puppet 3.x autoloader format path (lib/puppet/parser/functions/confine.rb) and the other with a Puppet 4.x autoloader format path (lib/puppet/functions/confine.rb). The autoloader format can be seen here: https://github.com/puppetlabs/puppet-specifications/blob/master/language/func-api.md#autoloading . With both autoloader functions in place and missing a metadata.json, everything would work With both functions and a metadata.json missing a dependency on the module containing the functions, we would get errors like the above With both functions and a proper metadata.json, everything would work With both functions missing and a proper metadata.json, we'd get an "Unknown function" error, as expected We probably hit an edge case, but the weird error message meant that it took quite a while to figure out what went wrong. The error did point to the correct line, but since we've used the function both before and after Puppet 4.x it wasn't obvious why we got an error, and especially why the error complained about types. I'm not sure how this should be resolved either. Perhaps look for duplicate function declarations in modules that have a metadata.json file? Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.