Jira (FACT-1441) Add "virtualization" fact that identifies AWS, Azure, etc

[Gareth Rushgrove (JIRA)]

Title: Message Title

Gareth Rushgrove commented on FACT-1441   Re: Add "virtualization" fact that identifies AWS, Azure, etc So, naming is hard. This issues goes from a specific need "We should add a fact that determines whether or not a VM is running in Azure" to a general solution: "virtualization": { "hypervisor": "kvm", "cloud": { "provider": "azure", "metadata": ... } But I think their is an assumption in the proposed structure which isn't explicit, and which I think is wrong. It assumes that a cloud provider is providing virtual machines running on top of a hypervisor. That's not 100% true of, for instance, Packet or Softlayer or Oracle Cloud. For instance the following would not make sense, because Packet isn't using virtualization. "virtualization": { "cloud": { "provider": "packet", I think the current name couples two things together, whether something is being provided as part of a cloud provider, and whether something is running atop a hypervisor. We already have the virtual fact for one of these things: https://docs.puppet.com/facter/latest/core_facts.html#virtual I'm wondering if instead of the this being nested under 'virtualization' (which also has the annoying property that it's the American spelling, which will cause typos in peoples code leading to bugs, presumably why virtual was the original keyword?) that `cloud` should simply be a top level keyword? Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.