Jira (PUP-6911) variables_refreshed_each_compilation test can fail uptime comparisons

[Jeremy Barlow (JIRA)]

Title: Message Title

Jeremy Barlow created an issue   Puppet / PUP-6911 variables_refreshed_each_compilation test can fail uptime comparisons Issue Type: Bug Assignee: Jeremy Barlow Components: QA Created: 2016/11/10 9:35 AM Priority: Normal Reporter: Jeremy Barlow The variables_refreshed_each_compilation acceptance test can fail when the uptime seconds that the test is comparing happen are for strings where the earlier uptime is lexicographically later than the later uptime. For example, this test failed in the puppetserver pipeline here with the following console output:   jubzk4qxrpdh8r2.delivery.puppetlabs.net (ubuntu1604-32-2) 03:09:15$ puppet agent -t --server ks6npbjxt60nblz.delivery.puppetlabs.net --environment variables_refreshed_each_compilation_nmjw1l2b ... Notice: local_9999_local   jubzk4qxrpdh8r2.delivery.puppetlabs.net (ubuntu1604-32-2) 03:09:19$ puppet agent -t --server ks6npbjxt60nblz.delivery.puppetlabs.net --environment variables_refreshed_each_compilation_nmjw1l2b ... Notice: local_10002_local   Warning: uptime did not change The assertions are made from here. The values of the variables being compared are strings. In this case though a string value of "9999" would be lexicographically greater than a string value of "10002", so the test fails. The test should be changed to do numeric comparisons of the uptimes in order to avoid the problem. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.