Jira (PUP-6914) ruby expand_path in file type breaks leading-tilde file resources

[Christopher Wood (JIRA)]

Title: Message Title

Christopher Wood created an issue   Puppet / PUP-6914 ruby expand_path in file type breaks leading-tilde file resources Issue Type: Bug Affects Versions: PUP 4.8.0 Assignee: Unassigned Components: Types and Providers Created: 2016/11/10 2:44 PM Environment: $ uname -a Linux cwl 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u2 (2016-10-19) x86_64 GNU/Linux $ cat /etc/debian_version 8.6 $ puppet --version 4.8.0 $ /opt/puppetlabs/puppet/bin/ruby --version ruby 2.1.9p490 (2016-03-30 revision 54437) [x86_64-linux] Priority: Minor Reporter: Christopher Wood This to reproduce: $ cat x.pp file { '/tmp/x~x': content => "x\n", }   file { '/tmp/~x': content => "x\n", }   file { '/tmp/x~': content => "x\n", } $ puppet apply /tmp/x.pp Notice: Compiled catalog for cwl.hostopia.com in environment production in 0.07 seconds Error: Could not set 'file' on ensure: user x20161110-10084-1ubfm2v doesn't exist at /tmp/x.pp:5 Error: Could not set 'file' on ensure: user x20161110-10084-1ubfm2v doesn't exist at /tmp/x.pp:5 Wrapped exception: user x20161110-10084-1ubfm2v doesn't exist Error: /Stage[main]/Main/File[/tmp/~x]/ensure: change from absent to file failed: Could not set 'file' on ensure: user x20161110-10084-1ubfm2v doesn't exist at /tmp/x.pp:5 Notice: Applied catalog in 0.12 seconds I can't by any stretch call myself a programmer, but it turns out people on stackoverflow are having related behaviour (huzzah googling for "ruby tilde filename", no quotes). http://stackoverflow.com/questions/2504646/how-to-open-files-relative-to-home-directory From the ruby docs, expand_path says that a ~user filename expands to that user's home directory. It doesn't seem to be quite what's going on here but it's still bringing in the username. https://ruby-doc.org/core-2.1.8/File.html#method-c-expand_path Sure enough, the file type uses expand_path to sort out where the :path is. https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/file.rb The bug part appears to be where the file type is implicitly presuming that the file path is not literal from the file resource, if I'm reading this right. (Not a programmer.) Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.