Jira (PUP-6923) Package provider should change install_options depending on option

[Peter Souter (JIRA)]

Title: Message Title

Peter Souter created an issue   Puppet / PUP-6923 Package provider should change install_options depending on option Issue Type: Bug Assignee: Unassigned Created: 2016/11/16 6:36 AM Priority: Normal Reporter: Peter Souter Most command line tools in the unix world take and equals sign for the long form, space for short form. For example with the gem command: gem install rails -s https://rubygems.org gem install rails --source=https://rubygems.org The long argument can take both (with or without equals, and it will work: gem install rails --source https://rubygems.org gem install rails --source=https://rubygems.org However, the short answer (99% of the time I've found) will error when using the short argument with the equals sign: gem install rails --source https://rubygems.org gem install rails --source=https://rubygems.org gem install rails -s=https://rubygems.org ERROR: While executing gem ... (OptionParser::InvalidArgument) invalid argument: -s=https://rubygems.org So, we should probably fix this so it doesn't error unexpectedly for the short args. There two approaches to this I can think of: 1) Change the default behavior to change the parameters passed as `arg value`, since this works for both 2) Scan to see if there is a long arg, then if it is, add equals So something like this for option 1: # Turns a array of options into flags to be passed to a command. # The options can be passed as a string or hash. Note that passing a hash # should only be used in case --foo=bar must be passed, # which can be accomplished with: # install_options => [ { '--foo' => 'bar' } ] # Regular flags like '--foo' must be passed as a string. # @param options [Array] # @return Concatenated list of options # @api private def join_options(options) return unless options   options.collect do |val| case val when Hash val.keys.sort.collect do |k| "#{k} #{val[k]}" end else val end end.flatten end Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.