Jira (HI-545) Environment data lookup stops processing hierarchy if sub_lookup for interpolation token can't find segment

[Taylan Develioglu (JIRA)]

Title: Message Title

Taylan Develioglu created an issue   Hiera / HI-545 Environment data lookup stops processing hierarchy if sub_lookup for interpolation token can't find segment Issue Type: Bug Assignee: Unassigned Created: 2016/11/22 5:55 AM Priority: Major Reporter: Taylan Develioglu If you have a hierarchy level that needs to interpolate a token that is a nested hash key but that key doesn't exist, the lookup silently ignores remaining hierarchy levels. In the following (environment) hiera.yaml there is no 'cluster' key in the 'serverdb' fact. The result is that lookup will ignore all levels after "ServerDB cluster". This is a severe issue, because a missing key could potentially break the entire infrastructure by reverting to module defaults. The relevant bit that I could find is in https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/lookup/sub_lookup.rb#L73-L75, after a throw while looking for the 'cluster' segment it immediately proceeds to (in our case) lookup module_data. This is repeated for each class parameter and we end up with nothing but default values. --- version: 4 datadir: data hierarchy: - name: "Trusted certname" backend: yaml path: "certname/%{::trusted.certname}"   - name: "FQDN" backend: yaml path: "fqdn/%{::facts.fqdn}"   - name: "ServerDB cluster" backend: yaml path: "cluster/%{::facts.serverdb.cluster}"   - name: "ServerDB role" backend: yaml paths: - "role/%{::facts.serverdb.role}/os/%{facts.os.name}/%{facts.os.release.major}" - "role/%{::facts.serverdb.role}/domain/%{::facts.domain}" - "role/%{::facts.serverdb.role}"   - name: "ServerDB environment" backend: yaml path: "environment/%{::facts.serverdb.environment}"   - name: "Network" backend: yaml path: "network/%{::facts.network_16}/%{::facts.network_24}" path: "network/%{::facts.network_16}"   - name: "Domain" backend: yaml path: "domain/%{::facts.domain}"   - name: "common" backend: yaml path: "common" To be safe, the run should halt with an error. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.