Jira (FACT-1559) CoreOS is recognized as Debian in last stable CoreOS version

[Brice Figureau (JIRA)]

Title: Message Title

Brice Figureau created an issue   Facter / FACT-1559 CoreOS is recognized as Debian in last stable CoreOS version Issue Type: Bug Affects Versions: FACT 3.5.0 Assignee: Unassigned Created: 2017/01/16 6:47 AM Environment: Latest stable CoreOS (1285.6.0), latest puppetlabs/puppet-agent container Priority: Major Reporter: Brice Figureau The following code is used to read /etc/os-release when deciding if the running OS is coreos: static unique_ptr<os_linux> get_os() { auto release_info = os_linux::key_value_file(release_file::os, {"NAME", "CISCO_RELEASE_INFO"}); auto const& name = release_info["NAME"]; if (name == "Cumulus Linux") { return unique_ptr<os_linux>(new os_cumulus()); } else if (name == "CoreOS") { return unique_ptr<os_linux>(new os_coreos()); } else { auto const& cisco = release_info["CISCO_RELEASE_INFO"]; boost::system::error_code ec; if (!cisco.empty() && is_regular_file(cisco, ec)) { return unique_ptr<os_linux>(new os_cisco(cisco)); } } return unique_ptr<os_linux>(new os_linux()); } More specifically it uses a straight comparison against the name field. In previous version of CoreOS, the /etc/os-release file was containing: # cat /etc/os-release NAME=CoreOS ID=coreos VERSION=1185.5.0 VERSION_ID=1185.5.0 BUILD_ID=2016-12-07-0937 PRETTY_NAME="CoreOS 1185.5.0 (MoreOS)" ANSI_COLOR="1;32" HOME_URL="https://coreos.com/" BUG_REPORT_URL="https://github.com/coreos/bugs/issues" It now contains the following: NAME="Container Linux by CoreOS" ID=coreos VERSION=1235.6.0 VERSION_ID=1235.6.0 BUILD_ID=2017-01-10-0545 PRETTY_NAME="Container Linux by CoreOS 1235.6.0 (Ladybug)" ANSI_COLOR="38;5;75" HOME_URL="https://coreos.com/" BUG_REPORT_URL="https://github.com/coreos/bugs/issues" Notice how CoreOS is now called "Container Linux by CoreOS" which makes the comparison on NAME not trigger. The code should better use the ID key as explained in the manpage: https://www.freedesktop.org/software/systemd/man/os-release.html Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.