Jira (PUP-7114) Re-vendor semantic_pupppet gem

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown created an issue   Puppet / PUP-7114 Re-vendor semantic_pupppet gem Issue Type: Task Assignee: Unassigned Created: 2017/01/19 11:35 AM Fix Versions: PUP 4.9.0 Priority: Blocker Reporter: Ethan Brown Channeling Moses Mendoza from https://groups.google.com/a/puppet.com/forum/#!topic/team-agent-and-platform/_1q5BWWyvxk Background In PA-621 , puppet-agent added a package conflict with puppet-server < 2.7.2 and pe-puppet-server < 2017.0.1.3. This was required because puppet added new vendored gem dependencies, and only puppet-server >= 2.7.2 satisfies those dependencies too. For even more context, see "extra context" at the bottom. One approach that has been settled on is to: Re-vendor the semantic_puppet gem so that the puppet-server packages don't need to have the gem installed (and to actually use a dependency in Puppet 5) See if the hocon gem is already properly guarded as a Hiera backend for when the gem is missing (it looks to be already) Make it so that gettext will work / load when the gem is present, but will not fail to load when the gem is not present (on older Puppet servers that don't have the gems vendored, we will stub the _ function) This ticket covers vendoring version 0.1.4 of the semantic_puppet gem back into the codebase. Rather than reverting all of the language related changes that were originally proposed in https://github.com/puppetlabs/puppet/pull/5094 and that ultimately landed in https://github.com/puppetlabs/puppet/pull/5399, it seems simpler to just grab the same code thats present in the gem and include that temporarily. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.