Jira (PUP-7218) systemd service provider missing double dash

[Rune Juhl Jacobsen (JIRA)]

Title: Message Title

Rune Juhl Jacobsen created an issue   Puppet / PUP-7218 systemd service provider missing double dash Issue Type: Bug Affects Versions: PUP 4.9.2 Assignee: Unassigned Components: Types and Providers Created: 2017/02/14 4:55 AM Labels: provider systemd service Priority: Normal Reporter: Rune Juhl Jacobsen The systemd service provider doesn't use double dashes for ending options, meaning that it will fail on any service with a name beginning with a - (dash): 13:52:54 runejuhl@tolu:~ $ /opt/puppetlabs/bin/puppet --version 4.9.2 13:53:00 runejuhl@tolu:~ $ /opt/puppetlabs/bin/puppet apply -e "service { '-h-asd': enable=>true}" | head Notice: Compiled catalog for tolu.petardo.dk in environment production in 0.27 seconds systemctl [OPTIONS...] {COMMAND} ...   Query or send control commands to the systemd manager.   -h --help Show this help --version Show package version --system Connect to system manager --user Connect to user service manager -H --host=[USER@]HOST Error: Failed to apply catalog: Broken pipe @ io_write - <STDOUT> Units starting with - are fairly common in systemd, e.g. the -.mount unit. For a quick fix, it looks like changing https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/service/systemd.rb#L47 like this would work (albeit only when enabling/disabling): - output = systemctl(action, @resource[:name]) + output = systemctl(action, '--', @resource[:name]) Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.