Issue #4461 has been updated by Markus Roberts. Status changed from Ready for Testing to Closed
commit:f54d843e4e585274f724c97f1b10288d8798a63b Fix #4461 - attempt to fix another performance issue ---------------------------------------- Bug #4461: Module path should be cached http://projects.puppetlabs.com/issues/4461 Author: Markus Roberts Status: Closed Priority: Normal Assigned to: Category: Target version: Affected version: Keywords: Branch: http://github.com/jes5199/puppet/tree/ticket/2.6.x/4461 As Brice writes on #4303: We’re constantly calling Puppet::Util::Autoload#module_directories, which in turns does a lot of filesystem stuff (File.join, FileTest.directory?), which are slow. With a large module path setting, this can be really worst. The call chain is the following: either coming from resource evaluation or to_resource <pre> Puppet::Resource#find_resource_type Puppet::Resource#find_builtin_resource_type Puppet::MetaType::Manager#type Puppet::Util::Autoload#load Puppet::Util::Autoload#searchpath Puppet::Util::Autoload#search_directories Puppet::Util::Autoload#module_directories </pre> Caching the module_directories returned list, makes the compilation 30% faster than 0.25.5 :) Unfortunately, as always with caching is to know when to invalidate the cache… The caching was removed in the patch for #1175, commit:ccc869ea48397235d7ba2a5695424eee4923cb9d because it wasn't environment sensitive. To keep things clearer I'm splitting this off as a separate issue; see #4302 of prior context. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
