Issue #4516 has been updated by Markus Roberts.

Status changed from Unreviewed to Needs design decision

Looking into it, this appears to me to have been an unexpected consequence of a 
bug; when no environment was specified $environment should have been 
"production" but was instead nil (and thus interpolated as if you had written:

<pre>
[master]
modulepath=/etc/puppet//modules
manifest=/etc/puppet//manifests/site.pp
</pre>

This had the (to me) odd behavior that specifying "production" (the default 
environment) wouldn't have worked. 


----------------------------------------
Bug #4516: $environment in puppet.conf breaks module/manifests that aren't in 
an environment
http://projects.puppetlabs.com/issues/4516

Author: Cody Herriges
Status: Needs design decision
Priority: Normal
Assigned to: 
Category: 
Target version: 
Affected version: 2.6.1rc1
Keywords: 
Branch: 


Generally I would say that when people use environments the have a modules and 
manifests directory at the base of their confdir so directory structure looks 
like:

    /etc/puppet
    /etc/puppet/manifests
    /etc/puppet/modules
    
When they then add a new environment to the puppet master's puppet.conf called 
foo they create the following:

    /etc/puppet
    /etc/puppet/foo/manifests
    /etc/puppet/foo/modules

When using the following puppet.conf to avoid the need to add a section to your 
puppet.conf every time you add an environment the absence of an environment on 
the client side results in module classes not being imported.  Things within an 
environment still function as expected when the client sets environment.

    [master]
    modulepath=/etc/puppet/$environment/modules
    manifest=/etc/puppet/$environment/manifests/site.pp

What I am referring to can be witnessed in the acceptance tests that I have 
written in my ticket/4516 branch at 
http://github.com/ody/puppet-acceptance/tree/ticket/4516/spec

The test puppet_master_check_use_of_dollarenvironment_in_puppetconf_2_spec.sh 
tests for a dev environment and no environment and fails.
The test puppet_master_check_use_of_dollarenvironment_in_puppetconf_spec.sh 
test for a dev and pro environment and succeeds.

I can't tell if this is intentional and/or I am missing something but it feels 
like a breakage of expected behavior.






-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to