Jira (PUP-7301) Avoid excessive type inference when checking instance_of?

[Thomas Hallgren (JIRA)]

Title: Message Title

Thomas Hallgren created an issue   Puppet / PUP-7301 Avoid excessive type inference when checking instance_of? Issue Type: Bug Affects Versions: PUP 4.9.3 Assignee: Unassigned Created: 2017/03/04 12:31 AM Fix Versions: PUP 4.9.4 Priority: Normal Reporter: Thomas Hallgren The type of an instance is often inferred when checking if it is instance of a Pcore type. I.e: t.instance_of?(o) can be written as: t.assignable?(<inferred type of o>) While this makes the instance check very simple and elegant, inferring a type can be very expensive in terms of CPU. Especially if the o is a large data structure. This means that inferring the type should not be done unless there's a real need for it. Consider the case where t is the type Scalar and o is a huge hash. There's no need to infer the type of o since it's already a known fact that a hash isn't a scalar. In addition to the Scalar example, there are a couple of similar low hanging fruits that needs to be fixed in the Pcore type system. The problem became very apparent in 4.9.x where the type of loaded Hiera data hashes is asserted. See PUP-7294 for more info. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.