1. Relying on YAML#to_yaml_properties has been deprecated since ruby 1.9.3
2. Note that Puppet::Resource::Status defines both to_yaml_properties and uses encode_with. As a result the serialization behavior depends on the ruby version and YAML engines (Syck vs Psych) and the 2 serialization methods could serialize different instance variables.
3. Ruby 2.1 changed how Array subclasses are serialized, and Ruby 2.3 does the same for
Hash subclasses. Note the ivars and the hash-with-ivars tag:

--- !ruby/array:MyArrayObject

internal:

- 1

ivars:

  :@foo: 2

--- !ruby/hash-with-ivars:MyHashObject

elements:

  1: 2

ivars:

  :@bar: 3

This means YAML data written by an agent running ruby 2.3 may not be readable by puppetserver using JRuby 1.7 (which is compatible with MRI ruby 1.9.3).

Puppet should consistently use PsychSupport and its encode_with methods. Similarly, we should be using init_with and leveraging the from_data_hash methods to deserialize instances. This ensures that objects explicitly state which data to serialize, and ensures that object initializers and setters are called during deserialization, instead of using bypassing that with instance_variable_set.

See discussion in https://github.com/puppetlabs/puppet/pull/4214#issuecomment-138691121

/cc Henrik Lindberg, Geoff Nichols, Ethan Brown

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7381) Consistently use encode_with for YAML serialization

Reply via email to