Jira (PUP-7414) Not relevant warning during a lookup when a YAML file is empty

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on PUP-7414   Re: Not relevant warning during a lookup when a YAML file is empty A yaml file that describes and empty hash is different from an empty yaml file, and is different from a completely empty file. This is illustrated by the following example: irb(main):004:0> YAML.load("--- {}\n") => {} irb(main):005:0> YAML.load("---\n") => nil irb(main):006:0> YAML.load("") => false Thus, your "empty hash" YAML files should have the following content: --- {} Not sure if we should equate nil with empty hash when loading yaml hashes in hiera - it would be a reasonable "do what I mean" interpretation since we are looking for a hash. For the false value case, that is probably an indication that something truly is wrong because the file is completely empty. IIRC there is a difference between YAML / Ruby versions that makes it difficult as not all of them make the distinction between nil and false. You are getting a warning, as the interpretation is to take nil/false as "empty hash", could mask an unintentional error. Given that there is a correct way to write an "empty hash yaml" I think we should leave the implementation as it is. Using the correct yaml syntax gets rid of the warning. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.