Jira (PUP-5756) Remove usage of win32-eventlog gem

[Moses Mendoza (JIRA)]

Title: Message Title

Moses Mendoza commented on PUP-5756   Re: Remove usage of win32-eventlog gem this failed CI on Japanese Windows hosts - specifically on a test to ensure that puppet uses a cached catalog if it can't contact the master. We're running ruby 2.1.8 (current agent ruby version) in these tests. I narrowed this down to the following: when ruby net/http can't resolve the intentionally-wrong master address, it generates an error message: "getaddrinfo: Hostname not known: # {host} " (IPSocket#getaddress). On Japanese windows, "getaddrinfo" is in English characters "Hostname not known" is in Japanese characters, specifically the following bytes: [130, 187, 130, 204, 130, 230, 130, 164, 130, 200, 131, 122, 131, 88, 131, 103, 130, 205, 149, 115, 150, 190, 130, 197, 130, 183, 129, 66] These bytes are valid Japanese in Encoding::Windows_31J, which is Encoding.default_external on this host ie => [130, 187, 130, 204, 130, 230, 130, 164, 130, 200, 131, 122, 131, 88, 131, 103, 130, 205, 149, 115, 150, 190, 130, 197, 130, 183, 129, 66] [34] pry(main)> bytes.pack('C*').force_encoding(Encoding::UTF_8) => "\x82\xBB\x82̂悤\x82ȃz\x83X\x83g\x82͕s\x96\xBE\x82ł\xB7\x81B" [35] pry(main)> bytes.pack('C*').force_encoding(Encoding::BINARY) => "\x82\xBB\x82\xCC\x82\xE6\x82\xA4\x82\xC8\x83z\x83X\x83g\x82\xCD\x95s\x96\xBE\x82\xC5\x82\xB7\x81B" [36] pry(main)> bytes.pack('C*').force_encoding(Encoding::Windows_31J) => "\x{82BB}\x{82CC}\x{82E6}\x{82A4}\x{82C8}\x{837A}\x{8358}\x{8367}\x{82CD}\x{9573}\x{96BE}\x{82C5}\x{82B7}\x{8142}" [37] pry(main)> Encoding.default_external = Encoding::Windows_31J => #<Encoding:Windows-31J> [38] pry(main)> bytes.pack('C*').force_encoding(Encoding::Windows_31J) => "そのようなホストは不明です。" When these strings are concatenated and returned as part of the exception, the exception message is encoded as Encoding::Binary - which makes sense since its bytes are quite possibly form two different character sets In puppet/util/windows/string and puppet/util/windows/eventlog, the `wide_string` method does an encode!('UTF-16LE') on the string, which fails with "\x82" to UTF-8 in conversion from ASCII-8BIT to UTF-8 to UTF-16LE. This is because ruby tries to convert the binary string to UTF-8 first, which results in invalid encoding, which then can't be encoded in to UTF-16LE This issue should not be present on Ruby 2.3.0 ruby 2.1.8 does not handle exceptions raised by TCPSocket#open inside Net::HTTP#start, instead allowing them to bubble up: 877 D "opening connection to #{conn_address}:#{conn_port}..." 878 s = Timeout.timeout(@open_timeout, Net::OpenTimeout) { 879 TCPSocket.open(conn_address, conn_port, @local_host, @local_port) 880 } Compared to 2.3.0 which does: 877 D "opening connection to #{conn_address}:#{conn_port}..." 878 s = Timeout.timeout(@open_timeout, Net::OpenTimeout) { 879 begin 880 TCPSocket.open(conn_address, conn_port, @local_host, @local_port) 881 rescue => e 882 raise e, "Failed to open TCP connection to " + 883 "#{conn_address}:#{conn_port} (#{e.message})" 884 end 885 } When patched in place to do so, ruby 2.1.8 both handles the exception as expected (generating the expected output for the test, ie "Using cached catalog for..." and the eventlog report succeeds. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.