Jira (PUP-7469) StringConverter#string_PRuntimeType has no tests and appears to be dead code

[Thomas Hallgren (JIRA)]

Title: Message Title

Thomas Hallgren commented on PUP-7469   Re: StringConverter#string_PRuntimeType has no tests and appears to be dead code Josh Cooper, the tests you're using are incorrect. They test converting the type into a string, not an instance of the type. An instance of Runtime is any object that isn't recognized as some other type, such as a Symbol. Example: 2.3.1 :002 > Puppet::Pops::Types::StringConverter.convert(:sym, "%s") => "sym" 2.3.1 :003 > Puppet::Pops::Types::StringConverter.convert(:sym, "%b") Puppet::Pops::Types::StringConverter::FormatError: Illegal format 'b' specified for value of Runtime type - expected one of the characters 'sqidxof' from /home/thhal/git/puppet/lib/puppet/pops/types/string_converter.rb:554:in `string_PRuntimeType' Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.