Jira (PUP-7471) misleading error message with classname errors

Henrik Lindberg (JIRA) Thu, 18 May 2017 05:18:14 -0700

Title: Message Title

PUP-7471

This happens because the parser is in a state where the only possible choice is a NAME (the 'classname' rule in the grammar) - and the keyword class is not a valid bareword / name. The error that surfaces comes from the grammar:

classname

  : NAME

  | WORD

  | CLASSREF

  | CLASS { error val[0], "'class' is not a valid classname" }

I believe the construct was put in place to error for things like:

{çode:puppet}

class class { }
class

{ class: }

class

{ 'class':}

They used to be possible.

Since the {{CLASS}} keyword is in the {{classname}} rule, it should be possible to accept the {{CLASS}} token there, and later validate it as part of a large context. That would however be the same problem as if it had been another WORD. Here is an illustration:

puppet apply -e 'foo "foo" { }'
Error: Could not parse for environment production: _expression_ is not valid as a resource, resource-default, or resource-override at line 1:5 on node ...

The 1:5 refers to the string "foo"

A very simple thing to do would be to change the error to say "'class' is not valid as a NAME/ bare-word" as that may be less confusing.

Note that the example logic looks like a function call to a function named 'class' with the RHS of what looks like a resource _expression_ (since it cannot be a class definition due to the string 'foo', and as a resource _expression_ 'foo' is not valid as a resource type reference. Since the grammar cannot recognize the constructs it cannot really say anything more intelligent.

So - simple fix (option 1), and if so what should the error say? or (option 2), make grammar lenient, and capture 'class' as an illegal name everywhere during validation (more work and possible performance issue). Ping David Schmitt

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7471) misleading error message with classname errors

Reply via email to