Jira (PUP-7515) data-in-modules: lookup() and automatic class parameter lookup result in different values

[Robert Heinzmann (JIRA)]

Title: Message Title

Robert Heinzmann commented on PUP-7515   Re: data-in-modules: lookup() and automatic class parameter lookup result in different values One more thing. It seems that hiera_hash is ignoring the lookup_options and does always use the hash lookup strategy. Is this correct ? I followed the guide at https://docs.puppet.com/puppet/4.10/hiera_migrate_v3_yaml.html#remove-dead-settings and migrated to lookup_options. In hiera3 behaviour could be changed by using :merge_behaviour: deeper in hiera.yaml at the global layer. Then hiera_hash did a merge lookup. I now set lookup_options to "merge: deep" at the environment layer, however this seems to be ignored for hiera_hash(). If so, how can I migrate from a hiera3 config with only the global layer that has :merge_behaviour: deeper enabled to Puppet with directory environments without modifying module code that uses hiera_hash and hiera. How can I enable deep merge for hiera_hash in this setup ? Can I do that, or do I need to migrate the puppet code to lookup or APL (which might be difficult for community code) ? Environment hiera.yaml: SERVER mymodule # cat /etc/puppetlabs/code/environments/production/hiera.yaml --- version: 5 defaults: datadir: data data_hash: yaml_data   hierarchy:   - name: "Per-OS defaults" path: "os/%{facts.os.family}.yaml"   - name: "Role Specific config" mapped_paths: [role, tmp, "role/%{tmp}.yaml"]   - name: "Common data" path: "common.yaml" Module hiera.yaml: SERVER mymodule # cat hiera.yaml --- version: 5 defaults: datadir: data data_hash: yaml_data   hierarchy:   - name: "Per-OS defaults" path: "os/%{facts.os.family}.yaml"   - name: "Role Specific config" mapped_paths: [role, tmp, "role/%{tmp}.yaml"]   - name: "Common data" path: "common.yaml" Role1 at the module layer: SERVER mymodule # cat data/role/role1.yaml --- mymodule::plugins: plugin1_role1: ensure: present version: modulelayer plugin3_role1: ensure: present version: modulelayer Role1 at the environment layer: SERVER mymodule # cat /etc/puppetlabs/code/environments/production/data/role/role1.yaml --- mymodule::plugins: plugin1_role1: version: envlayer plugin2_role1: version: envlayer Lookup Options "hash" at the environment (common.yaml): --- lookup_options: '^.*': merge: hash hiera_hash, lookup and class parameters result in proper result: SERVER mymodule # FACTER_role=role1 puppet apply --modulepath ../ -e 'include mymodule' --strict off --hiera_config=/dev/null Warning: /dev/null: File exists but does not contain a valid YAML hash. Falling back to Hiera version 3 default config Notice: Scope(Class[Mymodule]): hiera_hash : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): lookup : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): class param: 'plugins' : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Lookup Options "first" at the environment (common.yaml): --- lookup_options: '^.*': merge: first lookup and class parameters as expteced, however hiera_hash still a hash lookup: SERVER mymodule # FACTER_role=role1 puppet apply --modulepath ../ -e 'include mymodule' --strict off --hiera_config=/dev/null Warning: /dev/null: File exists but does not contain a valid YAML hash. Falling back to Hiera version 3 default config Notice: Scope(Class[Mymodule]): hiera : {"plugin_role1"=>{"version"=>"envlayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): hiera_hash : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): lookup : {"plugin_role1"=>{"version"=>"envlayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): class param: 'plugins' : {"plugin_role1"=>{"version"=>"envlayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Lookup Options "deep" at the environment (common.yaml): --- lookup_options: '^.*': merge: deep lookup and class parameters as expected, however hiera_hash still a hash lookup, no merging taking place: SERVER mymodule # FACTER_role=role1 puppet apply --modulepath ../ -e 'include mymodule' --strict off --hiera_config=/dev/null Warning: /dev/null: File exists but does not contain a valid YAML hash. Falling back to Hiera version 3 default config Notice: Scope(Class[Mymodule]): hiera_hash : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): lookup : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"ensure"=>"present", "version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Notice: Scope(Class[Mymodule]): class param: 'plugins' : {"baseplugin1"=>{"ensure"=>"present", "version"=>"1.2.3"}, "baseplugin2"=>{"ensure"=>"present", "version"=>"5.4.3"}, "plugin_role1"=>{"ensure"=>"present", "version"=>"envlayer"}, "plugin_role3"=>{"ensure"=>"present", "version"=>"modulelayer"}, "plugin_role2"=>{"version"=>"envlayer"}} Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.