Jira (PUP-7502) Remove Puppet::Log alias to Puppet::Util::Log

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-7502   Re: Remove Puppet::Log alias to Puppet::Util::Log The constant is used in more places than I expected: lib/puppet/application/filebucket.rb: Puppet::Log.newdestination(:console) lib/puppet/application/filebucket.rb: Puppet::Log.level = :debug lib/puppet/application/filebucket.rb: Puppet::Log.level = :info lib/puppet/util/log.rb:Puppet::Log = Puppet::Util::Log spec/unit/application/agent_spec.rb: Puppet::Log.expects(:newdestination).with("console") spec/unit/application/apply_spec.rb: Puppet::Log.expects(:newdestination).with("console") spec/unit/application/apply_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/apply_spec.rb: Puppet::Log.expects(:newdestination).with(:console) spec/unit/application/apply_spec.rb: expect(Puppet::Log.level).to eq(:debug) spec/unit/application/apply_spec.rb: expect(Puppet::Log.level).to eq(:info) spec/unit/application/cert_spec.rb: expect(Puppet::Log.level).to eq(:info) spec/unit/application/cert_spec.rb: expect(Puppet::Log.level).to eq(:debug) spec/unit/application/cert_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/cert_spec.rb: Puppet::Log.expects(:newdestination).with(:console) spec/unit/application/device_spec.rb: Puppet::Log.expects(:newdestination).with("console") spec/unit/application/doc_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/filebucket_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/filebucket_spec.rb: Puppet::Log.expects(:newdestination).with(:console) spec/unit/application/filebucket_spec.rb: expect(Puppet::Log.level).to eq(:debug) spec/unit/application/filebucket_spec.rb: expect(Puppet::Log.level).to eq(:info) spec/unit/application/filebucket_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/master_spec.rb: Puppet::Log.expects(:newdestination).with("console") spec/unit/application/master_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/resource_spec.rb: Puppet::Log.stubs(:newdestination) spec/unit/application/resource_spec.rb: Puppet::Log.expects(:newdestination).with(:console) spec/unit/application/resource_spec.rb: expect(Puppet::Log.level).to eq(:debug) spec/unit/application/resource_spec.rb: expect(Puppet::Log.level).to eq(:info) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).twice.with(has_entries(:level => :warning, :message => regexp_matches(/warning1|deprecation1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).never spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).once.with(has_entries(:level => :warning, :message => regexp_matches(/deprecation1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).twice.with(has_entries(:level => :warning, :message => regexp_matches(/warning1|deprecation1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).once.with(has_entries(:level => :warning, :message => regexp_matches(/warning1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).once.with(has_entries(:level => :warning, :message => regexp_matches(/warning1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).never spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).never spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).never spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).never spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).times(3).with(has_entries(:level => :err, :message => regexp_matches(/error1|error2|special/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).times(2).with(has_entries(:level => :err, :message => regexp_matches(/error1|error2/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).times(3).with(has_entries(:level => :err, :message => regexp_matches(/error[123]/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).times(2).with(has_entries(:level => :err, :message => regexp_matches(/error1|error2/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).twice.with(has_entries(:level => :warning, :message => regexp_matches(/warning1|deprecation1/))) spec/unit/pops/issues_spec.rb: Puppet::Log.expects(:create).twice.with(has_entries(:level => :err, :message => regexp_matches(/error[123]/))) spec/unit/type/ssh_authorized_key_spec.rb: Puppet::Log.level = :debug This was copy-pasta'ed into pops and ssh_authorized_key tests, and I bet it's in other places too. At this point, I'm inclined to close this as won't fix or move to PUP 6. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.