Issue #4487 has been updated by Matt Robinson.
I looks like a lot of the code in lib/puppet/rails/host.rb became obsolete with Luke's commit b9c95ebf81eeb78297003de2d0ed4ca048412393, and code that actually called the .store method was removed in 863c50b1273a7fa48d74fb74948938214b45967c when Puppet was version 0.24.8. I haven't proven this yet, but I'll pick this back up tomorrow to see if that's true and we can remove a bunch of that code. Markus, were you able to reproduce the initial bug in this ticket? I never could. Also, did you see your change make a difference in code execution, or was your change just based on reading through the code for suspicious lines? ---------------------------------------- Bug #4487: Environment column in hosts table updating incorrectly http://projects.puppetlabs.com/issues/4487 Author: Jason Koppe Status: Ready for Testing Priority: High Assignee: Matt Robinson Category: Target version: 2.6.2 Affected version: 2.6.0 Keywords: storedconfig, mysql, environment, hosts table Branch: http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4487 Posted on puppet-users at [thread/7237b49342ff9890](http://groups.google.com/group/puppet-users/browse_thread/thread/7237b49342ff9890) Below I null out the environment column, show that it's null for a particular host, then run puppetd a few times on the host. <pre> mysql for r...@localhost on indadm1> select * from hosts where name like 'iad-web2%'; +----+---------------------+---------------+-------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | id | name | ip | environment | last_compile | last_freshcheck | last_report | updated_at |source_file_id | created_at | +----+---------------------+---------------+-------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | 9 | iad-web2.indeed.net | 10.24.186.136 | NULL | 2010-08-06 03:31:23 | NULL | NULL | 2010-08-06 03:31:23 | NULL | 2010-06-08 19:47:22 | +----+---------------------+---------------+-------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ 1 row in set (0.00 sec) mysql for r...@localhost on indadm1> select * from hosts where name like'iad-web2%'; +----+---------------------+---------------+----------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | id | name | ip | environment | last_compile | last_freshcheck | last_report | updated_at | source_file_id | created_at | +----+---------------------+---------------+----------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | 9 | iad-web2.indeed.net | 10.24.186.136 | --- production | 2010-08-06 03:31:23 | NULL | NULL | 2010-08-06 03:32:42 | NULL | 2010-06-08 19:47:22 | +----+---------------------+---------------+----------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ 1 row in set (0.00 sec) mysql for r...@localhost on indadm1> select * from hosts where name like 'iad-web2%'; +----+---------------------+---------------+----------------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | id | name | ip | environment | last_compile | last_freshcheck | last_report | updated_at | source_file_id | created_at | +----+---------------------+---------------+----------------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ | 9 | iad-web2.indeed.net | 10.24.186.136 | --- "--- production" | 2010-08-06 03:32:50 | NULL | NULL | 2010-08-06 03:32:50 | NULL | 2010-06-08 19:47:22 | +----+---------------------+---------------+----------------------+---------------------+-----------------+-------------+---------------------+----------------+---------------------+ 1 row in set (0.00 sec) </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
