Jira (PUP-7617) Leftover /opt/puppet contents cause upgrades to fail on locale/config.yaml

[Adam Bottchen (JIRA)]

Title: Message Title

Adam Bottchen created an issue   Puppet / PUP-7617 Leftover /opt/puppet contents cause upgrades to fail on locale/config.yaml Issue Type: Bug Affects Versions: PUP 4.10.1 Assignee: Unassigned Created: 2017/06/02 2:25 PM Labels: maintenance triage Priority: Normal Reporter: Adam Bottchen If there happens to be any leftover files from older PE installations, it will cause the PE 2017.2.1 installation to fail because Puppet will end up pulling the wrong locale path: 2017-05-29 14:42:51,320 Running command: /opt/puppetlabs/puppet/bin/puppet infrastructure configure --detailed-exitcodes --modulepath /opt/puppetlabs/server/data/enterprise/modules /opt/puppetlabs/puppet/lib/ruby/2.1.0/psych.rb:464:in `initialize': No such file or directory @ rb_sysopen - /opt/puppet/share/locale/config.yaml (Errno::ENOENT) from /opt/puppetlabs/puppet/lib/ruby/2.1.0/psych.rb:464:in `open' from /opt/puppetlabs/puppet/lib/ruby/2.1.0/psych.rb:464:in `load_file' from /opt/puppetlabs/puppet/lib/ruby/gems/2.1.0/gems/gettext-setup-0.20/lib/gettext-setup/gettext_setup.rb:21:in `initialize' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:80:in `singleton class' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:55:in `<module:Puppet>' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet.rb:49:in `<top (required)>' from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:12:in `<top (required)>' from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' from /opt/puppetlabs/puppet/bin/puppet:4:in `<main>' * /opt/puppetlabs/puppet/bin/puppet infrastructure configure --detailed-exitcodes --modulepath /opt/puppetlabs/server/data/enterprise/modules * returned: 1 This appears to be due to how Puppet searches for the locale directory in https://github.com/puppetlabs/puppet/blob/4.10.1/lib/puppet.rb#L56-L73. https://github.com/puppetlabs/puppet/blob/4.10.1/lib/puppet.rb#L60 will set posix_system_locale_path to /opt/puppetlabs/puppet/share/locale, which is the correct path. The problem is that https://github.com/puppetlabs/puppet/blob/4.10.1/lib/puppet.rb#L62 runs regardless of the Puppet master not being a Windows machine and sets win32_system_locale_path to /opt/puppet/share/locale/config.yaml (because that would be /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/../../../../../puppet/share/locale). Since win32_system_locale_path is checked before posix_system_locale_path in the if/else block at https://github.com/puppetlabs/puppet/blob/4.10.1/lib/puppet.rb#L64-L73, the "windows" path will be used. If the old directory still exists, this path gets passed to GettextSetup, which leads to the failure. I'd think the fix would be to add logic to https://github.com/puppetlabs/puppet/blob/4.10.1/lib/puppet.rb#L68 to check if we are actually on a Windows system or Move the posix_system_locale_path check above the win32_system_locale_path one in the if/else block. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.