Jira (PUP-5912) Implement a human friendly PCore serialization format

[John Duarte (JIRA)]

Title: Message Title

John Duarte commented on PUP-5912   Re: Implement a human friendly PCore serialization format Thomas Hallgren, can you add some acceptance criteria to this ticket? I am unclear as to what the expected user experience is for this new feature. My assumption is that this would emit different formats for puppet generate based on the --render-as flag inherited by the face. However that assumption is obviously incorrect based on current results. Steps taken Using pre-release version of puppet-agent#master at SHA 649992ccd containing puppet at SHA 60feef5 Use the puppet/acceptance/tests/language/pcore_resource_types_should_have_precedence_over_ruby.rb to create a module with a custom resource type. Execute puppet help generate to see what applicable flags are available on master, puppet('help generate')   p61t5uvh4fmg2wh.delivery.puppetlabs.net (p61t5uvh4fmg2wh.delivery.puppetlabs.net) 11:48:10$ puppet help generate     USAGE: puppet generate <action>   Generates Puppet code from Ruby definitions.   OPTIONS: --render-as FORMAT - The rendering format to use. --verbose - Whether to log verbosely. --debug - Whether to log debug information.   ACTIONS: types Generates Puppet code for custom types   See 'puppet man generate' or 'man puppet-generate' for full help. Use the --render-as flag to attempt to render pcore The generated resource was manually deleted between attempts listed below. In both attempts, the pcore resource is generated as pcore, but no other rendering is emitted in the defined format. JSON request interaction on master, puppet('generate types --render-as json', '--environment', environment)   p61t5uvh4fmg2wh.delivery.puppetlabs.net (p61t5uvh4fmg2wh.delivery.puppetlabs.net) 11:55:50$ puppet generate types --render-as json --environment production Notice: Generating Puppet resource types. this indicates that we are running ruby code and should not be seen when running generated pcore resource Notice: Generating '/tmp/c98097.ozIHMy/codedir/environments/production/.resource_types/mycustomtype.pp' using 'pcore' format. YAML request interaction on master, puppet('generate types --render-as yaml', '--environment', environment)   p61t5uvh4fmg2wh.delivery.puppetlabs.net (p61t5uvh4fmg2wh.delivery.puppetlabs.net) 11:57:40$ puppet generate types --render-as yaml --environment production Notice: Generating Puppet resource types. this indicates that we are running ruby code and should not be seen when running generated pcore resource Notice: Generating '/tmp/c98097.ozIHMy/codedir/environments/production/.resource_types/mycustomtype.pp' using 'pcore' format. Here is the generated pcore resource for reference # This file was automatically generated on 2017-06-05 11:41:44 -0700. # Use the 'puppet generate types' command to regenerate this file.   # Create a new mycustomtype thing. Puppet::Resource::ResourceType3.new( 'mycustomtype', [   ], [ # Name of mycustomtype instance Puppet::Resource::Param(Any, 'name', true) ], { /(?m-ix:(.*))/ => ['name'] }, true, false) Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.