Jira (PUP-7615) puppet command leaks module command issues.

Henrik Lindberg (JIRA) Tue, 06 Jun 2017 05:41:48 -0700

Title: Message Title

PUP-7615

Adam Buxton Totally understand your frustration.

I looked into what we are currently doing, and the logic is like this (in module.rb):

  rescue JSON::JSONError => e

    msg = "#{name} has an invalid and unparsable metadata.json file. The parse error: #{e.message}"

    case Puppet[:strict]

    when :off, :warning

      Puppet.warning(msg)

    when :error

      raise FaultyMetadata, msg

end

{}

As you can see there is a simple opportunity here to change --strict=off to not generate an error. The issue then is that other problems are likely to occur because of this, and then you don't know why that happens. That is the reason we choose off and warning to be the same. Since warning is the factory setting for strict, we could change the meaning of off to not log anything.

What we cannot easily do is to have this be contextual (using one application vs. another) as we do not have a reasonable way of snaking that information through all the layers. In order to do that we have to make more substantial changes.

It seems that the value of turning off this warning is more valuable than the loss of strictness/quality, and I am for changing the meaning of "off" if a) you think that will help with the problem (simply run with --strict=off), and b) someone else seconds this approach. Ping Charlie Sharpsteen for second opinion.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7615) puppet command leaks module command issues.

Reply via email to